1584853 - Cannot remove color for default categories like Birthday, category no longer retains "Use Color" unchecked state

Status: RESOLVED FIXED

(Calendar :: Preferences, defect)

Description

[rogid]

Lightning 68.1.0

Under Edit->Preferences->Calendar->Categories, highlight "Birthday", select "Edit...", uncheck "Use Color", and select "OK" ... at this point I expect no color to be shown next to "Birthday", but instead a brown color is shown; if I select "Edit..." again I see that "Use Color" is checked again.

I believe this issue did not apply in Thunderbird 60.x

This issue is not occurring with any of my other categories (e.g. "Holiday")

Comment 1

[Stefan Sitter [:ssitter]]

Lightning ships with a default list of categories that includes "Birthday". Unfortunately those default categories always get a default color assigned, i.e. you cannot unset/remove the color because it falls back to the default color. If your other category was named "Holidays" instead of "Holiday" you would observe same problem.

Comment 2

[rogid]

it seems like it could be fixed to remember the "Use Color" state -- after all, this brown turd color wasn't showing up before updating to Thunderbird 68 -- or if it won't be fixed, it seems the "Use Color" checkbox should not be shown for the default categories since it doesn't work for them in 68.

Comment 3

[Stefan Sitter [:ssitter]]

Workaround:
In Options > Calendar set a color for the category. Open Options > Advanced > Config Editor. Search for the preference that matches your category, e.g. "calendar.category.color.birthday". Replace the current color value (e.g. "#FF0000") with "transparent" (all without quotes). After restart the color should be gone.

Comment 4

[rogid]

thanks for workaround - works well :-)

Comment 6

[WaltS48 [:walts48]]

So will the Edit unpick the "Use Color" check box not working be fixed?

Still not working in Daily Version 74.0a1 Build ID 20200113101537

Comment 7

[Geoff Lankow (:darktrojan)]

Attachment: 1584853-category-colour-clear-1.diff

It's your lucky day Walt. I happened to come across this in a list of bugs.

Comment 8

[bege10]

It's my lucky day, too. Thank you very much :-)

Comment 9

[Paul Morris [:pmorris]]

Comment on attachment 9120666 [details] [diff] [review]
1584853-category-colour-clear-1.diff

Review of attachment 9120666 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.  I checked that this does allow the user to remove a color on a built-in category.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/805903736871
When removing a category colour, set pref value to empty string instead of clearing it; r=pmorris

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/b11d7c703f33
follow-up - Fix linting error; rs=linting

Comment 12

[Rob Lemley [:rjl]]

Thunderbird 73.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/ba318f7e034450d4eae8bd5cb8b13cfd663d9693
https://hg.mozilla.org/releases/comm-beta/rev/27db17ea1a174d484cbcbf2cfbc403de3c74252e

Comment 13

[Rob Lemley [:rjl]]

Comment on attachment 9120666 [details] [diff] [review]
1584853-category-colour-clear-1.diff

This does not apply cleanly to esr68. xul -> xhtml differences I'm not comfortable fixing.

Comment 14

[Geoff Lankow (:darktrojan)]

Attachment: 1584853-category-colour-clear-esr.diff

My fault. The XUL to XHTML change was only a comment, but the change to the test doesn't apply because the test doesn't exist on ESR. I've removed the change.

Comment 15

[Rob Lemley [:rjl]]

Thunderbird 68.5.0:
https://hg.mozilla.org/releases/comm-esr68/rev/7aeb01eb56ab