158486 - review: Abstract out GenerateSQL into perl module, Patch v.1

Status: CLOSED INVALID

(Bugzilla :: Bugzilla-General, defect)

Description

[Gervase Markham [:gerv]]

Gervase Markham <[e-mail]> has requested review for bug #158474:
Abstract out GenerateSQL into perl module, attachment #92098 [details] [diff] [review]: Patch v.1.

http://bugzilla.mozilla.org/attachment.cgi?id=92098&action=edit

Additional Comments from Requester:

Louie - being a man interested in reports, could you review this? As the bug
explained, it's the first step towards my generic reporting patch (which is
written, but currently uses horrible cut-n-paste to get around the problem this
bug is fixing.)

Gerv

Comment 1

[Luis Villa]

Gerv- turns out I can't test this directly because it conflicts with the custom
fields patch from bug 91037, which we're running on our 2.16 install. Close
visual inspection would seem to imply it Does The Right Thing, though. Is that
sufficient for r= in this case? I'm suspecting no, but I'm really not sure of
the Rules for review in this case. [Are the rules actually posted anywhere, BTW?]

[Sorry about the delay in review, as well; with GNOME2.0.1 nearly out the door
and our own 2.16 nearly in production I should be more timely in the near future.]

Comment 2

[Gervase Markham [:gerv]]

Target bug is fixed.

Gerv

Comment 3

[Dave Miller [:justdave]]

in the process of eliminating the Review component (this is spam #1 of 2)
for the filters: "torgus borgus"

Comment 4

[Dave Miller [:justdave]]

Eliminating the Review component from the Bugzilla product.  (spam #2 of 2)
for the filters: "torgus borgus"

Comment 5

[Dave Miller [:justdave]]

clearing milestone on all DUPLICATE/WONTFIX/WORKSFORME/INVALID so they'll show
up as untriaged if they get reopened.  "Jiminy Cricket!" for the filters (and I
don't care if it's spelled wrong ;)