158497 - Templatise colchange.cgi

Status: RESOLVED FIXED

(Bugzilla :: User Interface, defect)

Description

[Gervase Markham [:gerv]]

Currently, colchange.cgi uses "print" to output its column change message. It
should use a template (probably the generic message one.)

Gerv

Comment 1

[Gervase Markham [:gerv]]

Attachment: Patch v.1

This patch does the following:
- Uses message.html.tmpl for the "resubmitting your query" message
- quotes hash values in accordance with common practice
- Moves the column descriptions into the template (for localisation)
- Reformats change-columns.html.tmpl to conform to coding and HTML standards
- Rewrites the text to be a little more descriptive

Note: I know there is still English left in the CGI; this sort of problem is
being dealt with over in bug 106640).

Gerv

Comment 2

[Tobias Burnus]

r=burnus

Nit:
+      [% "CHECKED" IF lsearch(collist, column) != -1 %]>
+      [% "CHECKED" IF NOT splitheader %]>
+      [% "CHECKED" IF splitheader %]>
should be better 'checked="checked"'

Comment 3

[Gervase Markham [:gerv]]

Fixed.

Checking in colchange.cgi;
/cvsroot/mozilla/webtools/bugzilla/colchange.cgi,v  <--  colchange.cgi
new revision: 1.28; previous revision: 1.27
done
Checking in template/en/default/list/change-columns.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/list/change-columns.html.tmpl,v
 <--  change-columns.html.tmpl
new revision: 1.4; previous revision: 1.3
done

Gerv