Only load object inspector reducer file, not the whole bundle
Categories
(DevTools :: Inspector, task, P2)
Tracking
(firefox71 fixed)
| Tracking | Status | |
|---|---|---|
| firefox71 | --- | fixed |
People
(Reporter: nchevobbe, Assigned: nchevobbe)
References
Details
Attachments
(2 files)
We load the entire bundle only to use the objectInspector reducer in devtools/client/inspector/reducers.js#24-28.
We should try to only load the reducer file instead.
|
Assignee | |
Updated•5 years ago
|
|
|
Assignee | |
Comment 1•5 years ago
|
||
This patch exposes the objectInspector reducer as a regular
file that can be required in the devtools codebase.
This should make things faster to start as we won't need
to load the entire bundle (especially for the inspector where
the reps is only used when navigating to specific subpanels).
This means we need to remove the flow typing for now since
we don't have a cross-toolbox build process like we have
in the debugger.
|
|
Assignee | |
Comment 2•5 years ago
|
||
Depends on D47728
|
||
Comment 3•5 years ago
|
||
If you want a simpler inspector-only fix which allows you to keep flow typing, the following patch worked fine for the inspector metrics tests: https://hg.mozilla.org/try/rev/53f3108af87869c2588843693f439d1af55d6eb3
Pushed by nchevobbe@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e63ea229519d Expose object inspector's reducer file. r=jlast. https://hg.mozilla.org/integration/autoland/rev/c06273b25769 Always lazy load Reps bundle. r=Honza.
|
||
Comment 5•5 years ago
|
||
Backed out 2 changesets (Bug 1584973) for devtools node failure.
Backout: https://hg.mozilla.org/integration/autoland/rev/bafc4821f21d9a6278440163c0f0f2a5b14ce747
Push that started the failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&revision=c06273b257694bd36d2ecff45d351c9bdd638b4a&selectedJob=269309344
Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=269309344&repo=autoland&lineNumber=371
|
|
||
Comment 6•5 years ago
|
||
There are also some mochitest devtools failures:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=269327286&repo=autoland&lineNumber=2625
|
|
Assignee | |
Comment 7•5 years ago
|
||
Fixed failures: https://treeherder.mozilla.org/#/jobs?repo=try&revision=a860164c426240667b80b4c89a132468318f03cd
Pushed by nchevobbe@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3bb37c5f2ba8 Expose object inspector's reducer file. r=jlast. https://hg.mozilla.org/integration/autoland/rev/df5e4d89de17 Always lazy load Reps bundle. r=Honza.
|
||
Comment 9•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/3bb37c5f2ba8
https://hg.mozilla.org/mozilla-central/rev/df5e4d89de17
Description
•