1585070 - Fix :-moz-window-inactive to work under Fission

Status: RESOLVED FIXED

(Core :: DOM: Navigation, defect, P1)

Description

[Kannan Vijayan [:djvj]]

https://searchfox.org/mozilla-central/rev/153feabebc2d13bb4c29ef8adf104ec1ebd246ae/dom/base/Document.cpp#6753

This simply retrieves the IsActive flag of the root window and returns it (if the root docshell exists). The IsActive flag should be moved to the BrowsingContext and this code changed to use the BrowsingContext tree to retrieve it.

Comment 1

[Chris Peterson [:cpeterson]]

Kannan says replacing nsIDocShellTreeItem calls should block enabling Fission in Nightly (M6).

Comment 2

[Chris Peterson [:cpeterson]]

We need to audit this use of the nsIDocShellTreeItem interface. With Fission enabled, Documents and nsDocShells for related frames, such as subframes and parent documents, may not be available within the current process and the corresponding nsIDocShellTreeItem methods will return null.

If this code is broken with Fission, fixing it blocks enabling Fission is Nightly.

If this code works as-is with Fission, we don't need to remove this usage of nsIDocShellTreeItem until when we remove nsIDocShellTreeItem entirely (bug 1607591) after we ship Fission MVP.

Fission documentation about replacing nsIDocShellTree Item:
https://wiki.mozilla.org/Project_Fission/DocShell_Tree_Replace

:farre's presentation with examples of replacing nsIDocShellTreeItem with BrowsingContext, WindowContext, SyncedContexts, and BrowsingContextGroup:
https://docs.google.com/presentation/d/1K4j6ngty64TZjJNS5qH-MBoOm3TI2dJedVsbH8jUhKE/edit#slide=id.g6e35225e5d_1_264

Comment 3

[Chris Peterson [:cpeterson]]

Auditing whether this use of nsIDocShellTreeItem breaks when Fission is enabled blocks Fission Nightly.

Comment 4

[Steven MacLeod [:smacleod]]

Attachment: Bug 1585070 - move nsPIDOMWindowOuter::mIsActive to BrowsingContext. r?kmag!

A new BrowsingContext field, isActiveBrowserWindow, has been added
to track the active browser window for the :-moz-window-inactive
pseudoclass. This field takes the place of
nsPIDOMWindowOuter::mIsActive.

With this change :-moz-window-inactive is now fission compatible.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/178fa7e29bb6
move nsPIDOMWindowOuter::mIsActive to BrowsingContext. r=farre

Comment 6

[Dorel Luca [:dluca]]

Backed out changeset 178fa7e29bb6 (bug 1585070) for Browser-chrome failures in general/browser_windowactivation.js. CLOSED TREE

Log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=312849990&repo=autoland&lineNumber=10693

Push with failure:
https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&revision=178fa7e29bb6ee5c6ed9f1a12a1b855cc8d35188

Backout:
https://hg.mozilla.org/integration/autoland/rev/74b3be6fcb93aba5e967179e49676f4fb6422851

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:smacleod, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 8

[Steven MacLeod [:smacleod]]

Was looking at M6b fission bugs before coming back to this. New patch is up which should fix things.

Comment 9

[Steven MacLeod [:smacleod]]

Adjusting summary as the patch fixes the entire feature and other related/broken code.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/18448a7ebf82
move nsPIDOMWindowOuter::mIsActive to BrowsingContext. r=kmag

Comment 11

[Noemi Erli[:noemi_erli]]

Backed out changeset 18448a7ebf82 (Bug 1585070) for causing failures in test_cocoa_window_focus.html CLOSED TREE

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&selectedTaskRun=W7LnDNQeTai3eqaXg0HbPQ.0&resultStatus=testfailed%2Cbusted%2Cexception&revision=18448a7ebf82de8ad97e2f978473fe35733bce43

Failure log: https://treeherder.mozilla.org/logviewer?job_id=322009795&repo=autoland&lineNumber=5893

Backout: https://hg.mozilla.org/integration/autoland/rev/637e750543b6dc2671789ff0808c7cdf3a93b755

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/35f3e90b3657
move nsPIDOMWindowOuter::mIsActive to BrowsingContext. r=kmag

Comment 13

[Steven MacLeod [:smacleod]]

Updated patch should fix the test breakages.

Comment 14

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/35f3e90b3657