1585077 - Remove usage of nsIDocShellTreeItem in mozilla::dom::IsInActiveTab

Status: NEW

(Core :: DOM: Navigation, defect, P2)

Description

[Kannan Vijayan [:djvj]]

https://searchfox.org/mozilla-central/rev/45f30e1d19bde27bf07e47a0a5dd0962dd27ba18/dom/base/Document.cpp#13474

This code checks to see if the given document is in an active tab, by comparing the window of the root item to the given window. This should probably just change to have BrowsingContext keep an updated field indicating which tabs are active or not. This field should not need to be synchronized between processes often as it should only happen when tab visibility changes.

Comment 1

[Chris Peterson [:cpeterson]]

Kannan says replacing nsIDocShellTreeItem calls should block enabling Fission in Nightly (M6).

Comment 2

[Henri Sivonen (:hsivonen)]

Since bug 1618102, nsIDocShellTreeItem is used on the parent-process code path only in this function.

Comment 3

[Chris Peterson [:cpeterson]]

Auditing whether this use of nsIDocShellTreeItem breaks when Fission is enabled blocks Fission Nightly.

Comment 4

[Henri Sivonen (:hsivonen)]

This should work fine when Fission is enabled. Could be written without nsIDocShellTreeItem using bug 1633723.

Comment 5

[Chris Peterson [:cpeterson]]

(In reply to Henri Sivonen (:hsivonen) from comment #4)

This should work fine when Fission is enabled. Could be written without nsIDocShellTreeItem using bug 1633723.

Thanks. In that case, this bug doesn't need to block shipping Fission MVP. I'll move this bug to a future milestone when we remove the nsIDocShellTreeItem interface entirely (someday).