Closed Bug 1585116 Opened 2 years ago Closed 2 years ago

Incorrect member of TOUCHINPUT checked for TOUCHINPUTMASKF_CONTACTAREA

Categories

(Core :: Widget: Win32, defect)

x86_64
Windows
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla71
Tracking Status
firefox71 --- fixed

People

(Reporter: cmartin, Assigned: botond)

Details

Attachments

(1 file)

In nsWindow.cpp line 6873, the following check is performed: pInputs[i].dwFlags & TOUCHINPUTMASKF_CONTACTAREA.

However, according to MSDN, TOUCHINPUTMASKF_CONTACTAREA is an expected value of the dwMask member of the TOUCHINPUT, not the dwFlags member.

Should be a very quick fix :)

We were testing the dwFlags field against TOUCHINPUTMASKF_CONTACTAREA, when
in fact that is meant to be tested against the dwMask field.

Assignee: nobody → botond
Pushed by bballo@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/98c607395fae
Fix usage of the TOUCHINPUT WinAPI structure in nsWindow::OnTouch(). r=cmartin
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla71
You need to log in before you can comment on or make changes to this bug.