1585121 - Ensure RDM tests work with fission-capable RDM on fission-enabled browser

Status: RESOLVED FIXED

(DevTools :: Responsive Design Mode, task, P1)

Description

[Brad Werth [:bradwerth]]

RDM tests need to work with two prefs turned on:

1. devtools.responsive.browserUI.enabled
2. fission.autostart

This will likely reveal many RDM test failures. Part of the fix will be updating the helper functions in devtools/client/responsive/test/browser/head.js.

Comment 2

[Chris Peterson [:cpeterson]]

Tentatively moving all bugs whose summaries mention "Fission" (or other Fission-related keywords) but are not assigned to a Fission Milestone to the "?" triage milestone.

This will generate a lot of bugmail, so you can filter your bugmail for the following UUID and delete them en masse:

0ee3c76a-bc79-4eb2-8d12-05dc0b68e732

Comment 3

[Chris Peterson [:cpeterson]]

Blocks enabling Fission in Nightly (M6)

Comment 4

[Brad Werth [:bradwerth]]

Some tests will take more effort to get working in automation. As with many RDM features, the test harness struggles to test behavior that can be verified interactively (see meta Bug 1520057). The patches here will disable some tests to be fixed in a follow-up bug.

Comment 5

[Brad Werth [:bradwerth]]

Attachment: Bug 1585121 Part 1: Make responsive/ui.js toolWindow into a read-only accessor, and use it in test functions.

Many RDM tests check ui.toolWindow to get access to the store and document.
Instead of changing all of those tests, this creates an accessor to do the
right thing depending on whether the new browser UI is in use.

Comment 6

[Brad Werth [:bradwerth]]

Attachment: Bug 1585121 Part 2: Define getter for responsive/ui.js viewportElement and use it in test functions.

Tests need to check properties of the viewport element (to check size,
typically). This getter provides a way to do that that works with the new
browser UI.

Depends on D63411

Comment 7

[Brad Werth [:bradwerth]]

Attachment: Bug 1585121 Part 4: Extend capabilities of addRDMTaskWithPreAndPost.

There are two functional changes:

1. Chain return values to task functions. This change allows the preTask
   return value to affect the behavior of the task, and for the return values
   of both of those functions to affect the behavior of the postTask. This can
   be used to create promises that are later awaited, for example.

2. Wait before calling the task. Many RDM tests have entry points that wait
   for the viewport to be loaded and the device list to be populated.
   Additionally, for new browser UI tests need to wait until the viewport has
   been sized and placed correctly. These waits have been moved into the
   addRDMTaskWithPreAndPost function.

Depends on D63412

Comment 8

[Brad Werth [:bradwerth]]

Attachment: Bug 1585121 Part 5: Disable tests that can't be easily modernized for new browser UI.

Depends on D63413

Comment 9

[Brad Werth [:bradwerth]]

Attachment: Bug 1585121 Part 6: Fix and activate RDM tests browser_a* through browser_d*.

Depends on D63416

Comment 10

[Brad Werth [:bradwerth]]

Attachment: Bug 1585121 Part 6: Activate test browser_contextmenu_inspect.js.

Depends on D63417

Comment 11

[Brad Werth [:bradwerth]]

Attachment: Bug 1585121 Part 7: Simplify test browser_device_custom.js.

This doesn't activate the test yet (pass true as final arg to addRDMTask),
because of some problems with addDeviceInModal with new browser UI. More
fixes needed there.

Depends on D63418

Comment 12

[Brad Werth [:bradwerth]]

Attachment: Bug 1585121 Part 3: Give new browser UI ability to response to content window resize.

Depends on D63412

Comment 13

[Brad Werth [:bradwerth]]

Attachment: Bug 1585121 Part 7: Fix and activate RDM tests browser_e* through browser_s*.

Changes to these tests are being bundled together to reduce the overall
number of patch parts.

Depends on D63417

Comment 14

[Brad Werth [:bradwerth]]

Attachment: Bug 1585121 Part 8: Fix and activate RDM tests browser_t* through browser_u*.

Depends on D64250

Comment 15

[Brad Werth [:bradwerth]]

Attachment: Bug 1585121 Part 9: Fix and activate RDM tests browser_v* through browser_z*.

Depends on D64493

Comment 16

[Brad Werth [:bradwerth]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=79d4dda4640e9d3f9e81d923979f6af45fd1c8dd

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/483a2fd12471
Part 1: Make responsive/ui.js toolWindow into a read-only accessor, and use it in test functions. r=mtigley
https://hg.mozilla.org/integration/autoland/rev/9e709b3953ac
Part 2: Define getter for responsive/ui.js viewportElement and use it in test functions. r=mtigley
https://hg.mozilla.org/integration/autoland/rev/a14a5c948448
Part 3: Give new browser UI ability to response to content window resize. r=mtigley
https://hg.mozilla.org/integration/autoland/rev/f162afdede72
Part 4: Extend capabilities of addRDMTaskWithPreAndPost. r=mtigley
https://hg.mozilla.org/integration/autoland/rev/109076b394ae
Part 5: Disable tests that can't be easily modernized for new browser UI. r=mtigley
https://hg.mozilla.org/integration/autoland/rev/9284a26e8ef4
Part 6: Fix and activate RDM tests browser_a* through browser_d*. r=mtigley
https://hg.mozilla.org/integration/autoland/rev/ba6b8b10f45e
Part 7: Fix and activate RDM tests browser_e* through browser_s*. r=mtigley
https://hg.mozilla.org/integration/autoland/rev/75bea7454e51
Part 8: Fix and activate RDM tests browser_t* through browser_u*. r=mtigley
https://hg.mozilla.org/integration/autoland/rev/dc12777129f3
Part 9: Fix and activate RDM tests browser_v* through browser_z*. r=mtigley

Comment 18

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/483a2fd12471
https://hg.mozilla.org/mozilla-central/rev/9e709b3953ac
https://hg.mozilla.org/mozilla-central/rev/a14a5c948448
https://hg.mozilla.org/mozilla-central/rev/f162afdede72
https://hg.mozilla.org/mozilla-central/rev/109076b394ae
https://hg.mozilla.org/mozilla-central/rev/9284a26e8ef4
https://hg.mozilla.org/mozilla-central/rev/ba6b8b10f45e
https://hg.mozilla.org/mozilla-central/rev/75bea7454e51
https://hg.mozilla.org/mozilla-central/rev/dc12777129f3