Closed Bug 1585187 Opened 5 months ago Closed 5 months ago

Implement missing context menu in emailWizard.xul

Categories

(Thunderbird :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 71.0

People

(Reporter: aleca, Assigned: aleca)

References

(Regression)

Details

(Keywords: regression, ux-efficiency)

Attachments

(1 file)

The html:input fields in the new Email Account Wizard don't have a context menu.
Also, there are some leftover references to the "textbox" element in the emailWizard.js file.

Attachment #9097529 - Flags: review?(mkmelin+mozilla)
Status: NEW → ASSIGNED
Comment on attachment 9097529 [details] [diff] [review]
1585187-emailwizard.patch

Review of attachment 9097529 [details] [diff] [review]:
-----------------------------------------------------------------

::: mail/components/accountcreation/content/emailWizard.js
@@ +127,5 @@
>  function setText(id, value) {
>    var element = e(id);
>    assert(element, "setText() on non-existant element ID");
>  
> +  if (element.localName == "input" || element.localName == "label") {

Well... that's unexpected. Seems like a misuse of this function. But then again, the whole function is pointless.
Attachment #9097529 - Flags: review?(mkmelin+mozilla) → review+
Keywords: checkin-needed

Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/387fad8b2d9c
Implement missing context menu in emailWizard.xul. r=mkmelin

Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 71.0
You need to log in before you can comment on or make changes to this bug.