158525 - permissions tab on userprefs.cgi doesn't distinguish permissions from buggroups

Status: NEW

(Bugzilla :: User Accounts, defect)

Description

[timeless]

Permissions
You have the following permission bits set on your account:

    * Can edit all aspects of any bug.
    * Can confirm a bug.
    * Webtools Security-Sensitive Bug

what i see:
<ability>can <verb>edit <subject>all aspects of any bug.
<ability>can <verb>confirm <subject>a bug.
<unknownpartofspeech>Webtools Security-Sensitive Bug<nopunctuation>

Comment 1

[Dave Miller [:justdave]]

That's because bug groups have names while system groups tell you what
permissions they relate to.

The obvious way to fix this is to separate the buggroups from the permissions on
this page just like they are on editusers.cgi.

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

:glob- is this still a worthwhile bug to fix?  If so, and if this makes a good first bug, can you link to the code, how to reproduce this problem, and what an ideal fix looks like?

Comment 3

[:glob ✱]

the code is in userprefs.cgi::DoPermissions() and template/en/default/account/prefs/permissions.html.tmpl

DoPermissions needs to be refactored to just pass in an array of group objects to the template, and doesn't need to query the database directly at all.
eg (untested):
  $vars->{has_bits} = $user->groups;
  $vars->{set_bits} = [ grep { $user->can_bless($_->id) } @{ $user->groups } ];

in the template, in addition to refactoring due to has_bits and set_bits changes, for groups which are bug-groups ($group-isbuggroup) we should output:
  Can view [% terms.bugs %] in the "[% $group->name FILTER html %]" group.
and for non-bug groups:
  Is a member of the "[% $group->name FILTER html %]" group.

Comment 4

[Matthew Mc Master]

Is anyone working on this currently? if not I'd like to take it on as my first bug.

Comment 5

[:glob ✱]

it's recommended to pick up a mentored bug as your first (this bug isn't mentored - the "mentor" field is empty), however as there's nobody working on it currently you're welcome to start here.

i haven't worked on bugzilla for some time now, so i'm not in a position to provide assistance i'm sorry; i recommend joining the #bugzilla channel on irc.mozilla.org and asking for help there.

Comment 6

[Matthew Mc Master]

Attachment: Patch v1

Refactored userprefs.cgi and permissions.html.tmpl along the lines Byron suggested

Comment 7

[Dylan Hardison [:dylan] (he/him)]

Hey, that change seems pretty reasonable (though I haven't tested it yet).

However, there are some tasks that we desperately need help with.
I want to make a Bugzilla 6 release that is incredibly close what you see on bugzilla.mozilla.org.

Please reach out to my email or join irc.mozilla.org #bugzilla and ping me. ('dylan' there).

Comment 8

[Firefox Bug Husbandry Bot]

Removing good-first-bug keyword because team does not have bandwidth to mentor at the moment.