Closed Bug 1585300 Opened 6 months ago Closed 6 months ago

Today Pane: Event list has wrong scrollbar color when using dark mode / dark theme

Categories

(Calendar :: Calendar Views, defect, minor)

Lightning 68
defect
Not set
minor

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: ssitter, Assigned: Paenglab)

Details

Attachments

(2 files)

Using Lightning 68.1.2 (Build ID: 20190930174329) with new profile.

STR:
Create new profile. Enable dark theme. Enable today pane. Create events and task until scrollbars are visible in today pane. Check scrollbar color.

Error:
The scrollbar in event list is using "light" colors. It should use "dark" colors like scrollbar in task list displayed below or scrollbar in unifinder displayed to the left.

Colour the agenda-listbox scrollbar.

Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #9097670 - Flags: review?(paul)
Attachment #9097670 - Flags: approval-calendar-esr?(paul)
Attachment #9097670 - Flags: approval-calendar-beta?(paul)
Comment on attachment 9097670 [details] [diff] [review]
1585300-agenda-listbox-scrollbar-color.patch

Review of attachment 9097670 [details] [diff] [review]:
-----------------------------------------------------------------

r+ I wasn't able to actually see the difference because my Ubuntu uses OS scrollbars/colors, but the changes seem fine.  

A question I had was whether it would make sense to use CSS variables for these colors?  I suppose it is tricky to sort out where they would be defined and how to access them?
Attachment #9097670 - Flags: review?(paul)
Attachment #9097670 - Flags: review+
Attachment #9097670 - Flags: approval-calendar-esr?(paul)
Attachment #9097670 - Flags: approval-calendar-esr+
Attachment #9097670 - Flags: approval-calendar-beta?(paul)
Attachment #9097670 - Flags: approval-calendar-beta+

(In reply to Paul Morris [:pmorris] from comment #2)

A question I had was whether it would make sense to use CSS variables for
these colors? I suppose it is tricky to sort out where they would be
defined and how to access them?

Yes, with the multiple appearances of this scrollbar colours it makes sense for variables. I'll do this in a new bug.

Land?

Yes.

Keywords: checkin-needed

Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/41993cc1ee09
Set scrollbar colors to the agenda-listbox when using themes. r=pmorris

Status: ASSIGNED → RESOLVED
Closed: 6 months ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 71
You need to log in before you can comment on or make changes to this bug.