1585302 - Thunderbird CE <richlistitem> related fixes

Status: RESOLVED FIXED

(Thunderbird :: General, task)

Description

[Magnus Melin [:mkmelin]]

Fix up some more <richlistitems> to be customized built-ins and properly named. Naming for consistency, and being a <richlistitem> for accessibility and other reasons. richlistbox doesn't like the list items to be anything but richlistitems.

https://searchfox.org/comm-central/search?q=extends+MozElements.MozRichlistitem&
case=false&regexp=false&path=

• rename agenda-header-richlist-item -> agenda-header-richlistitem
• rename agenda-allday-richlist-item -> agenda-allday-richlistitem
• renane agenda-richlist-item -> agenda-richlistitem

https://searchfox.org/comm-central/rev/266e9cc242cd0de076e85eb4aa0b8392fcb2ca01/chat/content/chat-account-richlistitem.js#40 - make sure to set the "is" attribute

https://searchfox.org/comm-central/rev/266e9cc242cd0de076e85eb4aa0b8392fcb2ca01/calendar/base/content/dialogs/calendar-invitations-dialog.js#39 - add the class instead of doing it here: https://searchfox.org/comm-central/rev/266e9cc242cd0de076e85eb4aa0b8392fcb2ca01/calendar/base/content/dialogs/calendar-invitations-dialog.js#235

• rename activity-base - this is just a base class which we shouldn't put into customElements. so drop this: https://searchfox.org/comm-central/rev/266e9cc242cd0de076e85eb4aa0b8392fcb2ca01/mail/components/activity/content/activity-widgets.js#108-110

• rename activity-event -> activity-event-richlistitem. This should also be a customized built-in extendind richlistitem, not a standalone CE

• same thing for activity-process and activity-warning

• chat-contact, chat-group, chat-imconv - rename these to have a -richlistitem suffix

• glodacomplete-base-richlistitem: just a base class, doesn't need to be put into customelements. https://searchfox.org/comm-central/rev/266e9cc242cd0de076e85eb4aa0b8392fcb2ca01/mailnews/db/gloda/content/autocomplete-richlistitem.js#212-216

gloda-contact-chunk, gloda-fulltext-all, gloda-fulltext-single, gloda-multi, gloda-single-identity, gloda-single-tag: all need -richlistitem suffix to name (and class renaming accordingly). Also making them customized built-ins instead.

You may want to see if there are more in there, these are the ones I found from a first look.

Comment 1

[Khushil Mistry [:khushil324]]

Attachment: Bug-1585302_richlistitem-related-fixes.patch

https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=93653eca9031404ce0765c7f261c0f5932d98287

Comment 2

[Magnus Melin [:mkmelin]]

Comment on attachment 9099525 [details] [diff] [review]
Bug-1585302_richlistitem-related-fixes.patch

Review of attachment 9099525 [details] [diff] [review]:
-----------------------------------------------------------------

Looks alright to me, though there is some bitrot. r=mkmelin

Comment 3

[Khushil Mistry [:khushil324]]

I will update it and send for the try-run.

Comment 4

[Khushil Mistry [:khushil324]]

Attachment: Bug-1585302_richlistitem-related-fixes.patch

https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=81074329d1858a4c0c5a8178dc60ec19c6aaf712

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/da6dd715f7cb
Thunderbird CE <richlistitem> related fixes. r=mkmelin

Comment 6

[Jorg K (CEST = GMT+2)]

You forgot https://searchfox.org/comm-central/search?q=agenda-richlist-item

Comment 7

[Khushil Mistry [:khushil324]]

Submitting a patch for that in while.

Comment 8

[Jorg K (CEST = GMT+2)]

Already fixed, see bug 1591553.

Comment 9

[Khushil Mistry [:khushil324]]

Thanks for the fix :)