Closed Bug 1585302 Opened 1 year ago Closed 1 year ago

Thunderbird CE <richlistitem> related fixes

Categories

(Thunderbird :: General, task)

task
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 71.0

People

(Reporter: mkmelin, Assigned: khushil324)

References

Details

Attachments

(1 file, 1 obsolete file)

Fix up some more <richlistitems> to be customized built-ins and properly named. Naming for consistency, and being a <richlistitem> for accessibility and other reasons. richlistbox doesn't like the list items to be anything but richlistitems.

https://searchfox.org/comm-central/search?q=extends+MozElements.MozRichlistitem&
case=false&regexp=false&path=

  • rename agenda-header-richlist-item -> agenda-header-richlistitem
  • rename agenda-allday-richlist-item -> agenda-allday-richlistitem
  • renane agenda-richlist-item -> agenda-richlistitem

https://searchfox.org/comm-central/rev/266e9cc242cd0de076e85eb4aa0b8392fcb2ca01/chat/content/chat-account-richlistitem.js#40 - make sure to set the "is" attribute

https://searchfox.org/comm-central/rev/266e9cc242cd0de076e85eb4aa0b8392fcb2ca01/calendar/base/content/dialogs/calendar-invitations-dialog.js#39 - add the class instead of doing it here: https://searchfox.org/comm-central/rev/266e9cc242cd0de076e85eb4aa0b8392fcb2ca01/calendar/base/content/dialogs/calendar-invitations-dialog.js#235

gloda-contact-chunk, gloda-fulltext-all, gloda-fulltext-single, gloda-multi, gloda-single-identity, gloda-single-tag: all need -richlistitem suffix to name (and class renaming accordingly). Also making them customized built-ins instead.

You may want to see if there are more in there, these are the ones I found from a first look.

Status: NEW → ASSIGNED
Comment on attachment 9099525 [details] [diff] [review]
Bug-1585302_richlistitem-related-fixes.patch

Review of attachment 9099525 [details] [diff] [review]:
-----------------------------------------------------------------

Looks alright to me, though there is some bitrot. r=mkmelin
Attachment #9099525 - Flags: review?(mkmelin+mozilla) → review+

I will update it and send for the try-run.

Keywords: checkin-needed

Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/da6dd715f7cb
Thunderbird CE <richlistitem> related fixes. r=mkmelin

Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 71.0
Regressions: 1591553

Submitting a patch for that in while.

Already fixed, see bug 1591553.

Thanks for the fix :)

You need to log in before you can comment on or make changes to this bug.