Closed Bug 1585388 Opened 5 years ago Closed 5 years ago

[wpt-sync] Sync PR 19446 - Fix SMIL interval restarting

Categories

(Core :: SVG, task, P4)

Product:
Core
Component:
SVG
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla71
Tracking Flags:
Tracking Status
firefox71 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 19446 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/19446
Details from upstream follow.

Fredrik Söderquist <fs@opera.com> wrote:

Fix SMIL interval restarting

When an interval restarts we won't necessarily get a new interval, but
just adjust the current interval (which could then potentially end).
Change CheckAndUpdateInterval(...) to reflect this, and narrow the
restart criteria in UpdateActiveState(...).
UpdateActiveState(...) was also only checking for
"inactive" -> "active/frozen" transitions to 'begin', but we need to
check for transitions from "frozen" as well.
Also re-order the check for 'end' so that it is before the one 'begin'.
This will mean that events should get dispatched like:

'begin', 'end', 'begin' and 'end'

when we encounter a restart (like in the testcase),
rather than as previously:

'begin', 'begin', 'end' and 'end'.

Bug: 998526
Change-Id: I56b2391fdcc22f3a22332d6eeb6aa469225497f6

Reviewed-on: https://chromium-review.googlesource.com/1821922
WPT-Export-Revision: 5f04e4d71f4128b2481581828a6f5090c4232d06

Component: web-platform-tests → SVG
Product: Testing → Core
Ran 1 tests and 1 subtests
OK     : 1
PASS   : 1
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f8374f10070c
[wpt PR 19446] - Fix SMIL interval restarting, a=testonly

https://hg.mozilla.org/mozilla-central/rev/f8374f10070c

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox71: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla71
You need to log in before you can comment on or make changes to this bug.