1585443 - Assertion failure: !IsCanonicalizedIP(topLevelURL), at toolkit/components/url-classifier/LookupCache.cpp:451

Status: RESOLVED FIXED

(Toolkit :: Safe Browsing, defect, P1)

Description

[Bob Clary [:bc] (inactive)]

1. http://46.166.167.16/threads/hijab-bank-bce-kisah-nyata.1328057/

• CAUTION * IP only weird url is suspicious. Be careful.

2. Assert Nightly Linux/Windows but not Beta.

Assertion failure: !IsCanonicalizedIP(topLevelURL), at /builds/worker/workspace/build/src/toolkit/components/url-classifier/LookupCache.cpp:451
#01: mozilla::net::(anonymous namespace)::TableData::DoLookup(nsUrlClassifierDBServiceWorker*) (/mozilla/builds/nightly/mozilla/firefox-debug/dist/
#02: mozilla::detail::RunnableFunction<mozilla::net::AsyncUrlChannelClassifier::CheckChannel(nsIChannel*, std::function<void ()>&&)::$_0>::Run() (/
#03: nsThread::ProcessNextEvent(bool, bool*) (/mozilla/builds/nightly/mozilla/firefox-debug/dist/bin/libxul.so)
#04: NS_ProcessNextEvent(nsIThread*, bool) (/mozilla/builds/nightly/mozilla/firefox-debug/dist/bin/libxul.so)
#05: mozilla::ipc::MessagePumpForNonMainThreads::Run(base::MessagePump::Delegate*) (/mozilla/builds/nightly/mozilla/firefox-debug/dist/bin/libxul.s
#06: MessageLoop::RunInternal() (/mozilla/builds/nightly/mozilla/firefox-debug/dist/bin/libxul.so)
#07: MessageLoop::Run() (/mozilla/builds/nightly/mozilla/firefox-debug/dist/bin/libxul.so)
#08: nsThread::ThreadFunc(void*) (/mozilla/builds/nightly/mozilla/firefox-debug/dist/bin/libxul.so)
#09: _pt_root (/mozilla/builds/nightly/mozilla/firefox-debug/dist/bin/libnspr4.so)
#10: start_thread (/build/glibc-KRRWSm/glibc-2.29/nptl/pthread_create.c:487 (discriminator 6))
#11: __GI___clone (/build/glibc-KRRWSm/glibc-2.29/misc/../sysdeps/unix/sysv/linux/x86_64/clone.S:97)
#12: ??? (???:???)

Comment 1

[Dimi Lee [:dimi]]

Attachment: Bug 1585443 - Remove IsCanonicalizedIP assertion. r?ehsan

Top-level URL and third-party URL can be an IP address, remove
IsCanonicalizedIP assertion and do not fragment a domain when the domain is an IP address

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1d05fb3ba169
Remove IsCanonicalizedIP assertion. r=Ehsan

Comment 3

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/1d05fb3ba169