1585515 - Inline Previews are re-fetched when the user clicks on a call stack frame

Status: RESOLVED FIXED

(DevTools :: Debugger, task)

Description

[Jason Laster [:jlast]]

we'll likely want to give memoizedAction a go for fetchScopes so that we stop re-doing work...

e.g. loadSourceText

The weird thing is that fetchScopes has getGeneratedFrameScope(getState(), frame.id)

A simpler alternative would be to add this check in generateInlinePreview

diff --git a/devtools/client/debugger/src/actions/pause/inlinePreview.js b/devtools/client/debugger/src/actions/pause/inlinePreview.js
index c3b575ba7118..7128d5a81194 100644
--- a/devtools/client/debugger/src/actions/pause/inlinePreview.js
+++ b/devtools/client/debugger/src/actions/pause/inlinePreview.js
@@ -32,6 +32,11 @@ export function generateInlinePreview(cx: ThreadContext, frame: ?Frame) {
     }

     const { thread } = cx;
+
+    if (getInlinePreviews(cx, thread, frame)) {
+      return;
+    }
+
     const originalFrameScopes = getOriginalFrameScope(
       getState(),
       thread,

Comment 1

[David Walsh :davidwalsh]

How did you discover this / see it?

When I pause on a breakpoint, and as I step through, I only ever see loadSourceTextPromise and loadSource being called once.

Comment 2

[David Walsh :davidwalsh]

Nevermind! I see what you mean now. Working on it!

Comment 3

[David Walsh :davidwalsh]

Attachment: Bug 1585515 - Prevent inline preview from being refetched r=jlast

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b1e07a798b0c
Prevent inline preview from being refetched r=jlast

Comment 5

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/b1e07a798b0c