Closed
Bug 1585519
Opened 5 years ago
Closed 5 years ago
[BinAST] Add MOZ_LIKELY/MOZ_UNLIKELY to error-handling code
Categories
(Core :: JavaScript Engine, task, P3)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla71
Tracking | Status | |
---|---|---|
firefox71 | --- | fixed |
People
(Reporter: arai, Assigned: arai)
References
Details
Attachments
(4 files)
at least in non-PGO assembly, error handling code's then-branch in BinASTParser method is placed inline and successful case needs to jump over that.
we can add MOZ_UNLIKELY to avoid this.
Assignee | ||
Comment 1•5 years ago
|
||
Depends on D48012
Assignee | ||
Comment 2•5 years ago
|
||
Depends on D48013
Assignee | ||
Comment 3•5 years ago
|
||
mozilla::Result is handled in bug 1585585.
Depends on D48014
Pushed by arai_a@mac.com: https://hg.mozilla.org/integration/autoland/rev/8ea58e64530b Part 1: Add MOZ_UNLIKELY to error handling code. r=Yoric https://hg.mozilla.org/integration/autoland/rev/d34594143118 Part 2: Add MOZ_UNLIKELY to error handling code in auto-generated code. r=Yoric https://hg.mozilla.org/integration/autoland/rev/e8cbe45ac452 Part 3: Add MOZ_UNLIKELY to error handling macro. r=Yoric
Assignee | ||
Comment 5•5 years ago
|
||
Pushed by btara@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/011193f69f2f Part 4: Remove unnecessary parentheses. r=Yoric CLOSED TREE
Comment 7•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/8ea58e64530b
https://hg.mozilla.org/mozilla-central/rev/d34594143118
https://hg.mozilla.org/mozilla-central/rev/e8cbe45ac452
https://hg.mozilla.org/mozilla-central/rev/011193f69f2f
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox71:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla71
You need to log in
before you can comment on or make changes to this bug.
Description
•