Closed Bug 1585519 Opened 1 year ago Closed 1 year ago

[BinAST] Add MOZ_LIKELY/MOZ_UNLIKELY to error-handling code

Categories

(Core :: JavaScript Engine, task, P3)

task

Tracking

()

RESOLVED FIXED
mozilla71
Tracking Status
firefox71 --- fixed

People

(Reporter: arai, Assigned: arai)

References

(Blocks 1 open bug)

Details

Attachments

(4 files)

at least in non-PGO assembly, error handling code's then-branch in BinASTParser method is placed inline and successful case needs to jump over that.
we can add MOZ_UNLIKELY to avoid this.

mozilla::Result is handled in bug 1585585.

Depends on D48014

Pushed by arai_a@mac.com:
https://hg.mozilla.org/integration/autoland/rev/8ea58e64530b
Part 1: Add MOZ_UNLIKELY to error handling code. r=Yoric
https://hg.mozilla.org/integration/autoland/rev/d34594143118
Part 2: Add MOZ_UNLIKELY to error handling code in auto-generated code. r=Yoric
https://hg.mozilla.org/integration/autoland/rev/e8cbe45ac452
Part 3: Add MOZ_UNLIKELY to error handling macro. r=Yoric
Pushed by btara@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/011193f69f2f
Part 4: Remove unnecessary parentheses. r=Yoric CLOSED TREE
You need to log in before you can comment on or make changes to this bug.