Closed Bug 1585520 Opened 6 years ago Closed 4 years ago

[BinAST] Try reordering Variant types in order to reflect likeliness of each type

Categories

(Core :: JavaScript Engine, task, P3)

Product:
Core
Component:
JavaScript Engine
Type:
task

Tracking

()

Status:
RESOLVED INCOMPLETE

People

(Reporter: arai, Unassigned)

References

Details

Based on Variant::match implementation, the first type will be checked first.

then, for example in BinASTTokenReaderBase::Context, the first type is RootContext, that won't happen frequently.
Reordering types might give us some perf improvement.

we can also check other variants as well.

Blocks: 1577764
No longer blocks: 1579862

BinASTTokenReaderBase::Context is removed in bug 1585234, but there are some more Variants.

Resolving BinAST bugs as Incomplete.

Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.