1585617 - convert remaining <textbox> usages in javascript to using html:input

Status: RESOLVED FIXED

(Thunderbird :: General, task, P1)

Description

[Magnus Melin [:mkmelin]]

+++ This bug was initially created as a clone of Bug #1562161 +++

Some related to chat:
There is at least this: https://searchfox.org/comm-central/rev/c1eb386b9615967e5d316bd24ae71db507901e58/mail/components/im/content/joinchat.js#73 and whatever related to that. Should also set required="required" for the input where needed.

Needs checking, probably only was needed for xbl: https://searchfox.org/comm-central/rev/c1eb386b9615967e5d316bd24ae71db507901e58/mail/components/im/content/chat-contact.js#170

https://searchfox.org/comm-central/rev/c1eb386b9615967e5d316bd24ae71db507901e58/mail/components/preferences/chat.js#98 "true" -> "disabled", or better just use toggleAttribute and get rid of the if-else

Other:

• https://searchfox.org/comm-central/rev/c1eb386b9615967e5d316bd24ae71db507901e58/mail/components/preferences/chat.js#98
• https://searchfox.org/comm-central/rev/c1eb386b9615967e5d316bd24ae71db507901e58/mail/components/customizableui/PanelMultiView.jsm#1508
• https://searchfox.org/comm-central/rev/c1eb386b9615967e5d316bd24ae71db507901e58/mail/components/preferences/connection.js#392

Comment 1

[Jorg K (CEST = GMT+2)]

And calendar?
https://searchfox.org/comm-central/search?q=%3Ctextbox&case=false&regexp=false&path=calendar

Comment 2

[Alessandro Castellani [:aleca]]

(In reply to Jorg K (GMT+2) from comment #1)

And calendar?
https://searchfox.org/comm-central/search?q=%3Ctextbox&case=false&regexp=false&path=calendar

I'll take care of the calendar stuff in a dedicated bug, thanks for the heads up.

Comment 3

[Alessandro Castellani [:aleca]]

Can I include also these?
https://searchfox.org/comm-central/search?q=%22textbox%22&case=false&regexp=false&path=mail

Comment 4

[Magnus Melin [:mkmelin]]

Please do.
inputField also doesn't exist anymore, so check these: https://searchfox.org/comm-central/search?q=%5C.inputField&case=false&regexp=true&path=%5Email (textbox.inputField is just the textbox, or rather the html:input now)

Comment 5

[Alessandro Castellani [:aleca]]

Attachment: 1585617-textbox-html-input.patch

This patch should include everything, except the qfbTextbox.inputField which is correct because it's a field inside the search-textbox custom element.

Here's the try run to see how many million tests I broke: https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=d84cd53d3c98e8e909470d1d39e1156148e2f77c

Comment 6

[Alessandro Castellani [:aleca]]

Wow, all the tests are green, sweet!

Comment 7

[Magnus Melin [:mkmelin]]

Comment on attachment 9098659 [details] [diff] [review]
1585617-textbox-html-input.patch

Review of attachment 9098659 [details] [diff] [review]:
-----------------------------------------------------------------

::: mail/components/compose/content/dialogs/EdDialogCommon.js
@@ +191,2 @@
>      // XXX Using the setTimeout is hacky workaround for bug 103197
> +    // Must create a new function to keep "input" in scope

Pretty sure this hack of a functnion could just go now...

::: mail/components/im/content/joinchat.js
@@ +70,5 @@
>        let div2 = document.createElementNS(
>          "http://www.w3.org/1999/xhtml",
>          "div"
>        );
> +      let textbox = document.createElementNS(

could be nice to update the name to be input instead

Comment 8

[Alessandro Castellani [:aleca]]

Attachment: 1585617-textbox-html-input.patch

I updated the patch, but I can't test it as I'm getting a segfault since this morning.
I'm asking a quick feedback review from Magnus just to be sure everything works and I didn't introduce any bug.

Comment 9

[Alessandro Castellani [:aleca]]

Comment on attachment 9098923 [details] [diff] [review]
1585617-textbox-html-input.patch

I fixed my segfault issue and texted this locally.
Everything seems to work as expected.
I launched a try-run just to be sure: https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=eeed4e6593ac56e4d04bada923c3dc2baa100c42

Comment 10

[Alessandro Castellani [:aleca]]

A couple of failures in Z4 and Z3 which I can't reproduce locally.
Any insight on this, Jorg?

Comment 11

[Jorg K (CEST = GMT+2)]

The Z4 is known, I've rerun the Z3.

Comment 12

[Alessandro Castellani [:aleca]]

I did another try-run here: https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=8a7efd5a0e1ee9317470f82f25ef1b09cadbb38d
The Z3 and Z4 are green, but now X3 are failing, but since other patches are part of the try run I don't think it's my fault...hopefully.

Maybe this can be checked in? Is the last bit to complete the textbox removal.

Comment 13

[Jorg K (CEST = GMT+2)]

X3, see bug 1587199.

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/0daedafc7c20
convert remaining <textbox> usages in JavaScript to using html:input. r=mkmelin