1585697 - Refactor CycleCollectorStats a little

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task, P3)

Description

[Jon Coppeard (:jonco)]

There's a bunch of statics globals in nsJSEnvironment.cpp that concern time spent running forget skippable that could be moved into CycleCollectorStats, and a few other things that could be tidied up.

Comment 1

[Jon Coppeard (:jonco)]

Attachment: Bug 1585697 - Move CycleCollectorStats definition to the top of the file r?mccr8

This needs to be defined before FireForgetSkippable for the subsequnt patches.

Comment 2

[Jon Coppeard (:jonco)]

Attachment: Bug 1585697 - Make CycleCollectorStats instance static for consistency with other globals r?mccr8

I'm not sure what if there's a preference either way, but all the other globals in nsJSEnvironement.cpp are static so I made the CycleCollectorStats global static too.

Depends on D47918

Comment 3

[Jon Coppeard (:jonco)]

Attachment: Bug 1585697 - Move forget skippable stats into CycleCollectorStats class r?mccr8

Depends on D47919

Comment 4

[Jon Coppeard (:jonco)]

Attachment: Bug 1585697 - Refactor nsJSContext::EndCycleCollectionCallback to split out telemetry and logging code into CycleCollectorStats methods r?mccr8

Depends on D47920

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c3c52501f575
Move CycleCollectorStats definition to the top of the file r=mccr8
https://hg.mozilla.org/integration/autoland/rev/5da58cc85764
Make CycleCollectorStats instance static for consistency with other globals r=mccr8
https://hg.mozilla.org/integration/autoland/rev/d2a59efd0e55
Move forget skippable stats into CycleCollectorStats class r=mccr8
https://hg.mozilla.org/integration/autoland/rev/129bdec0c8d2
Refactor nsJSContext::EndCycleCollectionCallback to split out telemetry and logging code into CycleCollectorStats methods r=mccr8

Comment 6

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/c3c52501f575
https://hg.mozilla.org/mozilla-central/rev/5da58cc85764
https://hg.mozilla.org/mozilla-central/rev/d2a59efd0e55
https://hg.mozilla.org/mozilla-central/rev/129bdec0c8d2