1585800 - [wpt-sync] Sync PR 19477 - [workers] Correct variable name

Status: RESOLVED FIXED

(Core :: DOM: Workers, task, P4)

Description

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 19477 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/19477
Details from upstream follow.

Mike Pennisi <[e-mail]> wrote:

[workers] Correct variable name

This test generates subtests based on the value of a binding named
unexpected. Prior to this commit, no such binding was declared by the
test, so it failed to declare any subtests and instead produced a
ReferenceError. Currently, testharness.js interprets this result as a
failing "single-page test," although it will soon be more accurately
reported as a harness error [1].

Update the test to declare a binding named unexpected.

[1] https://github.com/web-platform-tests/rfcs/blob/master/rfcs/single_test.md

---

This change makes the test run to completion, but it seems like there is a more
fundamental problem with the semantics. The subtest titles state that the
relevant object should not be exposed, but the assertion verifies that the
corresponding property is present in the global object.

Should the assertion be changed from assert_true to assert_false?

(This is in service of https://github.com/web-platform-tests/rfcs/pull/28)

Comment 1

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=99a2abb2e140b92dee2b0151c5bba666f54bca7f

Comment 2

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=666e7af73edbbdeb63a48668d13a49f9d482d714

Comment 3

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=909d4d5a394f69fb91ca96a8f355e9ae4aa655fa

Comment 4

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

GitHub CI Results

wpt.fyi PR Results Base Results

Ran 1 tests and 65 subtests

Firefox

OK : 1
PASS : 57
FAIL : 7

Chrome

OK : 1
PASS : 60
FAIL : 4

Safari

OK : 1
FAIL : 1

New tests that's don't pass

/workers/semantics/interface-objects/003.any.sharedworker.html
The CanvasGradient interface object should be exposed: Firefox: FAIL, Chrome: PASS, Safari: MISSING
The Path2D interface object should be exposed: Firefox: FAIL, Chrome: PASS, Safari: MISSING
The CanvasPath interface object should be exposed: Firefox: FAIL, Chrome: FAIL, Safari: MISSING
The SharedWorker interface object should be exposed: Firefox: FAIL, Chrome: FAIL, Safari: MISSING
The CanvasPattern interface object should be exposed: Firefox: FAIL, Chrome: PASS, Safari: MISSING
The ApplicationCache interface object should be exposed: Firefox: FAIL, Chrome: FAIL, Safari: MISSING
The WritableStream interface object should be exposed: Firefox: FAIL, Chrome: PASS, Safari: MISSING

Comment 5

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Attachment: Bug 1585800 [wpt PR 19477] - [workers] Correct variable name, a=testonly

Automatic update from web-platform-tests
[workers] Correct assertions

This test generates subtests based on the value of a binding named
unexpected. Prior to this commit, no such binding was declared by the
test, so it failed to declare any subtests and instead produced a
ReferenceError. Currently, testharness.js interprets this result as a
failing "single-page test," although it will soon be more accurately
reported as a harness error [1].

Update the test to assert the presence of the properties as originally
intended.

[1] https://github.com/web-platform-tests/rfcs/blob/master/rfcs/single_test.md

Co-authored-by: Ms2ger <[e-mail]>

--

wpt-commits: ca2983ebb0a61e076e13ce848ab999293093f4cb
wpt-pr: 19477

Comment 6

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Attachment: Bug 1585800 [wpt PR 19477] - Update wpt metadata, a=testonly

wpt-pr: 19477
wpt-type: metadata

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c8c878dfb658
[wpt PR 19477] - [workers] Correct variable name, a=testonly
https://hg.mozilla.org/integration/autoland/rev/77f4518a5433
[wpt PR 19477] - Update wpt metadata, a=testonly

Comment 8

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/c8c878dfb658
https://hg.mozilla.org/mozilla-central/rev/77f4518a5433