1585808 - Add UTM parameters to the "Learn more about this breach" link in breach notifications.

Status: VERIFIED FIXED

(Firefox :: about:logins, enhancement, P1)

Description

[Lesley Norton [:lnorton]]

We should add UTM parameters to the "Learn more about this breach" link inside breach notifications. There is already a telemetry probe for this event but adding UTM parameters would improve Monitor's ability to recognize traffic coming from this link in our analytics dashboard.

Comment 1

[David Durst [:ddurst]]

We will need this for 70.

Comment 2

[MarniePW [:marnie]]

[Tracking Requested - why for this release]: Per :ssage, this is needed for Skyline.

Comment 3

[Liz Henry (:lizzard) (relman/hg->git project)]

OK, if you can land this asap we can get it into the Thursday (early)_ morning build)

Comment 4

[Maxx Crawford [:mcrawford :maxx :maxxcrawford]]

Attachment: Bug 1585808 - Add UTM parameters to the "Learn more about this breach" link in breach notifications. r=MattN

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8cf556022ec5
Add UTM parameters to the "Learn more about this breach" link in breach notifications. r=MattN

Comment 6

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/8cf556022ec5

Comment 7

[Maxx Crawford [:mcrawford :maxx :maxxcrawford]]

Comment on attachment 9099677 [details]
Bug 1585808 - Add UTM parameters to the "Learn more about this breach" link in breach notifications. r=MattN

Beta/Release Uplift Approval Request

• User impact if declined: We may lose some data capture opportunities for users who exit about:logins and land on monitor.frefox.com.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This patch adds two UTM parameters to the "Learn More URL link within the breach notification UI within about:logins. This is a minor change that only appends to the final URL.
• String changes made/needed:

Comment 8

[David Durst [:ddurst]]

I'd like to hold off on this while we nail down verification of the parameter set via Nightly with Marketing.

Comment 9

[Liz Henry (:lizzard) (relman/hg->git project)]

OK, I'll just keep it un-approved for now.

Comment 10

[David Durst [:ddurst]]

It would seem that we were not quite straight on our params with Marketing, so let's remove this uplift request and focus on the blessed implementation in 1587550.

Comment 11

[Matthew N. [:MattN]]

Re-opening to fix this patch since it was incorrect.

Comment 13

[Raul Gurzau (:RaulG)]

Backout link: https://hg.mozilla.org/integration/autoland/rev/5e6d2b2ffd077ea12996710349c57d2f71de5495

Comment 14

[Matthew N. [:MattN]]

Spreadsheet of UTM parameters used: https://docs.google.com/spreadsheets/d/1seC5WwSJHmWMjUPXS0-C5wbozIWAZf4i0pOTpYu5mH8/edit#gid=0

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a2f59445b0ad
Add UTM parameters to the "Learn more about this breach" link in breach notifications. r=MattN

Comment 16

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/a2f59445b0ad

Comment 17

[Ciprian Georgiu, Desktop QA]

The only difference I can see between the UTM parameters provided in comment 14 and a fixed build from treeherder 71.0a1 (2019-10-10) is the "/", which is missing after the breach account. Please observe the following links:

• 71.0a1 latest Nightly: https://monitor.firefox.com/breach-details/CrackedTO?utm_source=firefox-desktop&utm_medium=referral&utm_campaign=about-logins&utm_content=about-logins

• UTM parameters (as per spreadsheet) https://monitor.firefox.com/breach-details/{{BREACH DETAIL}}/?utm_source=firefox-desktop&utm_medium=referral&utm_campaign=about-logins&utm_content=about-logins

Maxx, I'm not sure if this was something intended, would you mind letting me know?

Comment 18

[Maxx Crawford [:mcrawford :maxx :maxxcrawford]]

This is as intended. Before this build, the breach link that was generated (without the UTM) also did not have a trailing /. This is not an issue. Tagging Justin to also confirm. He provided the spreadsheet to us originally.

Comment 19

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 9099677 [details]
Bug 1585808 - Add UTM parameters to the "Learn more about this breach" link in breach notifications. r=MattN

OK for uplift for beta 14.

Comment 20

[Julien Cristau [:jcristau] (back April 22)]

https://hg.mozilla.org/releases/mozilla-beta/rev/01fd845cda3f

Comment 21

[Justin Crawford [:hoosteeno] [:jcrawford]]

(In reply to Maxx Crawford from comment #18)

This is as intended. Before this build, the breach link that was generated (without the UTM) also did not have a trailing /. This is not an issue. Tagging Justin to also confirm. He provided the spreadsheet to us originally.

The trailing slash between the URL and the parameters is not essential. Thanks!

Comment 22

[Ciprian Georgiu, Desktop QA]

Thank you for the clarifications!

This is verified fixed on latest Nightly 71.0a1 and Beta 70.0b14 under macOS 10.14, Ubuntu 18.04 x64 and Windows 10 x64.