Closed Bug 1585889 Opened 5 years ago Closed 5 years ago

[wpt-sync] Sync PR 19487 - [LayoutNG] Fix clusterfuzz crash

Categories

(Core :: CSS Parsing and Computation, task, P4)

Product:
Core
Component:
CSS Parsing and Computation
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla71
Tracking Flags:
Tracking Status
firefox71 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 19487 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/19487
Details from upstream follow.

Aleks Totic <atotic@chromium.org> wrote:

[LayoutNG] Fix clusterfuzz crash

Using empty Optional\<MinMax> to indicate that MinMax value
should not matter caused trouble with ng_length_utils
ResolveInlineLengthInternal, when max-width was fit-content.

Use MinMax(0, LayoutUnitMax) to indicate intrinsic size does
not matter instead. It accomplishes the same goal, computed
size does not get clamped by intrinsic.

I've also tested running it with width:max-content out of
fear that we might end up with too wide OOF, but that did
not happen.

Bug: 1010798
Change-Id: Ife11b3d9637be91cc0648b7f8485af51f07108bb

Reviewed-on: https://chromium-review.googlesource.com/1837118
WPT-Export-Revision: 396d2a049bd018495e3a4ce4ab22ab3d8a75d59b

PR 19487 applied with additional changes from upstream: 2f0b747361dc9b66b7dfc9e28d91fd84f346dd49
Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
## GitHub CI Results
wpt.fyi [PR Results](https://wpt.fyi/results/?sha=b1ce1e6a07bf3fee644ade7fe17e649ec465f7fc&label=pr_head) [Base Results](https://wpt.fyi/results/?sha=b1ce1e6a07bf3fee644ade7fe17e649ec465f7fc&label=pr_base)

Ran 1 tests and 39 subtests

### Firefox
  OK  : 1
  PASS: 39

### Chrome
  OK  : 1
  PASS: 36
  FAIL: 3

### Safari
  OK  : 1
  PASS: 36
  FAIL: 3
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/39986b1b8895
[wpt PR 19487] - [LayoutNG] Fix clusterfuzz crash, a=testonly

https://hg.mozilla.org/mozilla-central/rev/39986b1b8895

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox71: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla71
You need to log in before you can comment on or make changes to this bug.