Add missing margin to the "Group by" and "Label by" dropboxes
Categories
(DevTools :: Memory, defect, P3)
Tracking
(firefox71 verified)
| Tracking | Status | |
|---|---|---|
| firefox71 | --- | verified |
People
(Reporter: itiel_yn8, Assigned: itiel_yn8)
References
Details
Attachments
(1 file)
Add this:
#select-label-display,
#select-display,
to add missing margin to the "Group by" and "Label by" dropboxes.
Also related, aren't these rules irrelevant now? If they are, they can at least be combined:
https://searchfox.org/mozilla-central/rev/35cc00a25c4471993fdaa5761952bd3afd4f1731/devtools/client/themes/memory.css#95-101
(I can't see where any of them houses a span)
Also, can't these rules be combined into a single .devtools-toolbar > label?
https://searchfox.org/mozilla-central/rev/35cc00a25c4471993fdaa5761952bd3afd4f1731/devtools/client/themes/memory.css#85-93,103-107
|
||
Comment 1•5 years ago
|
||
Thanks for the report!
This issue has been reported in bug 1242223 in the past.
Actually what you propose is exactly what I've put in my review in https://phabricator.services.mozilla.com/D35595 :) So we're pretty much aligned!
Given that that bug seems stalled now, if you want to work on this it's totally fine. I can dupe that bug here if you want to. Tell me!
Also, can't these rules be combined into a single .devtools-toolbar > label?
Well, they're a bit different (not the same selector), but they could probably be merged into one ruleset.
I'm not a big fan of these complex selectors, nowadays I prefer much more simpler class selectors. But this CSS is old and has seen many contributors ;-).
I'd say that we shouldn't fix things that are not broken, especially on this tool where we don't work much. So let's focus on the "space" issue!
|
|
||
Updated•5 years ago
|
|
||
Updated•5 years ago
|
Pushed by jwajsberg@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7bd5a6c6242d Add missing margin to the "Group by" and "Label by" dropboxes in the memory inspector. r=julienw
|
||
Comment 5•5 years ago
|
||
| bugherder | ||
|
||
Updated•5 years ago
|
Fixed on latest Nightly.
Description
•