Closed Bug 158593 Opened 22 years ago Closed 22 years ago

[RFE] It should be posible to drag items from the media tab and the links tab in page info.

Categories

(SeaMonkey :: Page Info, enhancement)

enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla1.2alpha

People

(Reporter: nick, Assigned: nick)

References

Details

Attachments

(2 files, 3 obsolete files)

It should be posible to start a drag from the media and links tabs to (e.g.)
drop them into an open tab, or create a shortcut to that URL.
Severity: normal → enhancement
Attached patch Patch (obsolete) — Splinter Review
Keywords: patch, review
Status: NEW → ASSIGNED
Blocks: 69295
Comment on attachment 92167 [details] [diff] [review]
Patch

I like it. Just break the function up into smaller chunks with some blank
lines, and it'll be cool. I'll have to test it tommorrow though.
Attached patch Broken in chunks (obsolete) — Splinter Review
Attachment #92167 - Attachment is obsolete: true
Note that the XUL part of the patch has a line which depends in other patch, the
one in bug 158245 (which has already been reviewed and super-reviewed and is
waiting for approval =/).

But it's easy to fix, this patch just need to add that ondraggesture to the <tree>.
Comment on attachment 92178 [details] [diff] [review]
Broken in chunks

thanks, that's really the only 'style' issue I care about.

Just to make sure, do you have to cal addDataFlavor(), doesn't it add the
flavor automagically if needed when you call setTransferData()?
Attachment #92178 - Flags: review+
Keywords: review
Comment on attachment 92178 [details] [diff] [review]
Broken in chunks

+function onBeginLinkDrag(event,urlField,descField)
+{
+  if (event.originalTarget.localName != "treechildren")
+    return;
+  var tree = event.target;
+  if(!("treeBoxObject" in tree))
+    tree=tree.parentNode;

Be consistent with how you use space between "if" and the opening paren, I'd
suggest you always insert the space, but if the majority of the code in this
file doesn't use a space then don't insert the space, but be consistent!

+  if ( !transArray )
+    return;

Also be consistent with how you use spaces inside the parens in if expressions
(and function calls too, of course). I'd suggest you loose the spaces, i.e.:

  if (!transArray)

...
+  if ( !trans )
+    return;

Same thing.

+  trans.addDataFlavor("text/x-moz-url");
...
+  trans.setTransferData ("text/x-moz-url", stringURL, stringURL.data.length *
2 );

Again, be consistent with your usage of space before the opening paren, loose
the space on the above line.

sr=jst if you clean up those nits.
Attachment #92178 - Flags: superreview+
Oh, and be consistent with space-after-comma too in argument lists.
Attached patch Addes and removed spaces (obsolete) — Splinter Review
Attachment #92178 - Attachment is obsolete: true
Attachment #92995 - Flags: superreview+
Attachment #92995 - Flags: review+
Target Milestone: --- → mozilla1.2alpha
Attachment #92995 - Attachment is obsolete: true
Also, I add some return false to avoid the warning of the js engine
Comment on attachment 95050 [details] [diff] [review]
fix contractID&interface problem for current codebase

personally I wouldn't have cared about the warning, that one is often
meaningless.

Anyway, r=db48x
Attachment #95050 - Flags: review+
This was commited long ago! =)
Status: ASSIGNED → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: