1585931 - Blurry fonts from Firefox 71.0a1 (2019-10-02) (64-bit)

Status: VERIFIED FIXED

(Core :: Graphics: Text, defect, P1)

Description

[drJeckyll]

Attachment: bad.png - blurry fonts

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:71.0) Gecko/20100101 Firefox/71.0

Steps to reproduce:

As from 71.0a1 (2019-10-02) (64-bit) some fonts appear blurry. See shots

Comment 1

[drJeckyll]

Attachment: bad1.png - blurry fonts

Comment 2

[drJeckyll]

Attachment: good.png - same site - looking good

Comment 3

[drJeckyll]

Attachment: good1.png - same site - looking good

Comment 4

[drJeckyll]

Bad shots are from 71.0a1 (2019-10-02) (64-bit). Good ones are from yesterday build 71.0a1 (2019-10-01) (64-bit).

This is Gentoo Linux. Shots taken from the same machine and same time.

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The priority flag is not set for this bug.
:lsalzman, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 6

[Lee Salzman [:lsalzman]]

What does your fontconfig hint style setup look like in /etc/fonts/conf.d or similar? Also, what version of freetype are you using?

Comment 7

[drJeckyll]

Fri Jul 5 22:33:46 2019 >>> media-libs/freetype-2.10.1

<match target="font">
<edit mode="assign" name="rgba"><const>rgb</const></edit>
<edit mode="assign" name="hinting"><bool>true</bool></edit>
<edit mode="assign" name="hintstyle"><const>hintfull</const></edit>
<edit mode="assign" name="antialias"><bool>true</bool></edit>
<edit mode="assign" name="lcdfilter"><const>lcddefault</const></edit>
</match>

BUT, I don't change anything about fonts. Just update firefox. Also if I go back to "good" version of firefox fonts are back to normal.

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

The priority flag is not set for this bug.
:lsalzman, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 9

[Lee Salzman [:lsalzman]]

Attachment: Bug 1585931 - don't use subpixel positioning for Fontconfig fonts if full hinting is requested. r?jfkthame

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/49e3720bafb4
don't use subpixel positioning for Fontconfig fonts if full hinting is requested. r=jfkthame

Comment 11

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/49e3720bafb4

Comment 12

[Lee Salzman [:lsalzman]]

Comment on attachment 9102948 [details]
Bug 1585931 - don't use subpixel positioning for Fontconfig fonts if full hinting is requested. r?jfkthame

Beta/Release Uplift Approval Request

• User impact if declined: Regression on Linux where users who have explicitly forced Fontconfig hinting of text will not get the requested hinting. Just missed the cut-off for getting this change in 71...
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): In 71, subpixel positioning was enabled for text on Linux. This change just disables subpixel positioning again for users who have forced hinting of text, effectively just putting things back the way they used to be for those users.
• String changes made/needed:

Comment 13

[Pascal Chevrel:pascalc (PTO until April 26)]

Hi drjeckyll, could you confirm that you are no longer experiencing the bug in the last 72 nightlies? Thanks!

Comment 14

[BugBot [:suhaib / :marco/ :calixte]]

Changing the priority to p1 as the bug is tracked by a release manager for the current beta.
See What Do You Triage for more information

Comment 15

[drJeckyll]

At least for me, fonts looks much better now. Not sure if they back what were before, but they are not blurry or uneven.

Comment 16

[drJeckyll]

Attachment: good3.png - today view

Comment 17

[drJeckyll]

Attachment: good4.png - today view

Comment 18

[Pascal Chevrel:pascalc (PTO until April 26)]

Thanks, let's uplift to beta then :)

Comment 19

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9102948 [details]
Bug 1585931 - don't use subpixel positioning for Fontconfig fonts if full hinting is requested. r?jfkthame

Low risk patch for some Linux configurations, verified as fixed on Nightly by the reporter, uplift approved for 71 beta 4, thanks.

Comment 20

[Oana Pop-Rus]

https://hg.mozilla.org/releases/mozilla-beta/rev/c8ab20957ee7

Comment 21

[Daniel Cicas [:dcicas], Release QA]

Hello,

I could not reproduce this bug using Fx 71.0a1 BuildID: 20191002214349 on Ubuntu x64 18.04. I will remove the qe verify + flag. Thank you for confirming the fix drjeckyll!

Comment 22

[Daniel Cicas [:dcicas], Release QA]

Hi drjeckyll, if you would be so kind, can you verify that the fix is working for you on Firefox Beta 71.0b5 (https://archive.mozilla.org/pub/firefox/candidates/71.0b5-candidates/build1/) unfortunately we could not reproduce this issue on our hardware.

Thank you!

Comment 23

[drJeckyll]

(In reply to Daniel Cicas [:dcicas], Release QA from comment #22)

Hi drjeckyll, if you would be so kind, can you verify that the fix is working for you on Firefox Beta 71.0b5 (https://archive.mozilla.org/pub/firefox/candidates/71.0b5-candidates/build1/) unfortunately we could not reproduce this issue on our hardware.

Thank you!

It looks good to me

Comment 24

[drJeckyll]

Attachment: Firefox Beta 71.0b5 - 1

Comment 25

[drJeckyll]

Attachment: Firefox Beta 71.0b5 - 2

Comment 26

[Daniel Cicas [:dcicas], Release QA]

Thank you for verifying this issue!

Marking this bug as verified as per the reporters comments.