Closed Bug 1585949 Opened 2 years ago Closed 2 years ago

Get rid of regex use in geckodriver unit tests

Categories

(Testing :: geckodriver, enhancement, P1)

Version 3
enhancement

Tracking

(firefox71 fixed)

RESOLVED FIXED
mozilla71
Tracking Status
firefox71 --- fixed

People

(Reporter: ato, Assigned: ato)

Details

Attachments

(1 file)

We use regex in testing/geckodriver/src/test.rs for test::check_deserialize().
We should use serde_json::from_value() and serde_json::to_value()
like we do in the Marionette crate instead, as regex is an expensive library to compile.

Assignee: nobody → ato
Status: NEW → ASSIGNED
Priority: -- → P1

Regular expressions are expensive, both in runtime cost and
compile-time cost of the regex crate. This is the first step
towards getting rid of the regex dependency in geckodriver.

Pushed by atolfsen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f4d6ae41f387
geckodriver: get rid of regex use in tests; r=webdriver-reviewers,whimboo
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla71
You need to log in before you can comment on or make changes to this bug.