1585961 - Get rid of regex for parsing Firefox version number

Status: NEW

(Testing :: geckodriver, enhancement, P3)

Description

[Andreas Tolfsen ❲:ato❳]

We parse the output of --version as part of the capabilities negotiation in testing/geckodriver/src/capabilities.rs:83.

This is because the output may contain more data we don’t care about.

We could easily replace this with a small lexer.

Comment 1

[Andreas Tolfsen ❲:ato❳]

I’m going to have a look at this quickly.

Comment 2

[Andreas Tolfsen ❲:ato❳]

I have a patch for this locally that needs tests, but this is on my back-burner.

Edit: Lost the patch.

Comment 3

[Andreas Tolfsen ❲:ato❳]

version_from_binary() should in fact be using mozversion::Version::from_str() so we only parse the version number in one place.

However, mozversion still relies on a regexp:
https://searchfox.org/mozilla-central/rev/9b99e1d9c6cf83539674cb016c7373f549ba59ca/testing/mozbase/rust/mozversion/src/lib.rs#119

Comment 4

[Andreas Tolfsen ❲:ato❳]

Attachment: firefoxversions.txt

Attaching list of historical Firefox versions. This was extracted from https://product-details.mozilla.org/1.0/firefox.json.

This is useful input for version parsing tests.

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee is inactive on Bugzilla, so the assignee is being reset.