Open Bug 1585969 Opened 4 months ago Updated 2 days ago

Tab titles should sync with the editable titles from Compare views

Categories

(Tree Management :: Perfherder, enhancement, P3)

enhancement

Tracking

(Not tracked)

People

(Reporter: igoldan, Unassigned)

References

Details

(Keywords: good-first-bug, Whiteboard: [lang=js])

Attachments

(1 file)

No description provided.
No longer blocks: 1525997
Keywords: good-first-bug
Whiteboard: [lang=js]

Hi,

I would like to work on this Bug, if I can get some more information as to what is required

Thanks

Flags: needinfo?(igoldan)

Hello, I will explain what is to be done right below:

  1. Go to this link
  2. Click on Recent and select some random revision
  3. Click Compare
  4. Click on the title, Perfherder Compare Revisions, and change it. Then press Enter or click on Save button.
  5. The title has changed in the URL and into the page, but the tab title has not.

Perfherder's components of interest:
ui/perfherder/compare/ComparePageTitle.jsx

The tab title should change in sync with page title.

If there are any questions, I am happy to help.

Octavian explained very well. Basically, the tab's title should change its initial default to whatever the user types over that Perfherder Compare Revisions input.

Flags: needinfo?(igoldan)

Does the tab name must be kept after refreshing the page or accessing into a URL with the "pageTitle" query param set?

Yes, like the editable page title does already.

You need to log in before you can comment on or make changes to this bug.