1585994 - Bad contrast in "This time search with" text with certain themes

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P1)

Description

[Asif Youssuff]

Seeing bad contrast/hard to read text when using megabar on Ubuntu Eoan with the Plata Noir theme: https://gitlab.com/tista500/plata-theme

STR:

1. Install and enable https://gitlab.com/tista500/plata-theme
2. run nightly
3. type in text into address bar

The contrast present in the "This time search with" text is hard to read -- certainly harder than with megabar off.

Comment 1

[Asif Youssuff]

Attachment: plata-bad-contrast.png

Comment 2

[Dão Gottwald [:dao]]

Can you post a screenshot with the megabar turned off for comparison?

Comment 3

[Asif Youssuff]

Attachment: Screenshot from 2019-10-04 05-01-12.png

One off search styling seems to have been updated in nightly -- I had originally compared to stable (attached), which looks fine.

Comment 4

[Dão Gottwald [:dao]]

I think we need to stop using var(--panel-disabled-color) in the view since we don't use the panel background anymore.

Comment 5

[Dão Gottwald [:dao]]

Attachment: Bug 1585994 - Stop using --panel-disabled-color in the urlbar. r=harry

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3e34d378fab6
Stop using --panel-disabled-color in the urlbar. r=harry

Comment 7

[Alexandru Michis [:malexandru]]

Backed out changeset 3e34d378fab6 for causing bc failures in browser_ext_themes_autocomplete_popup.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/4d771109e528cf09c8ddbcff41dcee7974211f0d

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&searchStr=%28bc&tochange=4d771109e528cf09c8ddbcff41dcee7974211f0d&fromchange=5fe79445226119093c4cffffe7b1ee4fa1e1b12d&group_state=expanded&selectedJob=288244415

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=288244415&repo=autoland&lineNumber=17640

[task 2020-02-10T18:49:48.042Z] 18:49:48 INFO - TEST-PASS | toolkit/components/extensions/test/browser/browser_ext_themes_autocomplete_popup.js | Urlbar popup action color should be set to #30e60b - "rgb(48, 230, 11)" == "rgb(48, 230, 11)" -
[task 2020-02-10T18:49:48.046Z] 18:49:48 INFO - Buffered messages finished
[task 2020-02-10T18:49:48.047Z] 18:49:48 INFO - TEST-UNEXPECTED-FAIL | toolkit/components/extensions/test/browser/browser_ext_themes_autocomplete_popup.js | Urlbar popup separator color should be set to #ffffff with alpha - "rgb(200, 197, 194)" == "rgba(255, 255, 255, 0.5)" - JS frame :: chrome://mochitests/content/browser/toolkit/components/extensions/test/browser/browser_ext_themes_autocomplete_popup.js :: test_popup_url :: line 240
[task 2020-02-10T18:49:48.048Z] 18:49:48 INFO - Stack trace:
[task 2020-02-10T18:49:48.049Z] 18:49:48 INFO - chrome://mochitests/content/browser/toolkit/components/extensions/test/browser/browser_ext_themes_autocomplete_popup.js:test_popup_url:240
[task 2020-02-10T18:49:48.050Z] 18:49:48 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1062
[task 2020-02-10T18:49:48.051Z] 18:49:48 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1097
[task 2020-02-10T18:49:48.052Z] 18:49:48 INFO - chrome://mochikit/content/browser-test.js:nextTest/<:925
[task 2020-02-10T18:49:48.053Z] 18:49:48 INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:808

Comment 8

[Alexandru Michis [:malexandru]]

Another failure (on asan): https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=288250764&repo=autoland&lineNumber=3735

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/739ac41b6683
Stop using --panel-disabled-color in the urlbar. r=harry

Comment 10

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/739ac41b6683

Comment 11

[Marco Bonardo [:mak]]

Dao, should we uplift this?

Comment 12

[Dão Gottwald [:dao]]

I think this can ride the 75 train.

Comment 13

[Cristian Fogel [:cfogel]]

Ran into some issues in an attempt to install Plata on Ubuntu 19.04(Dingo). While it might be the fact that this is on a VM there are some dependencies that I can't seem to install.

@Asif any chance you could confirm if the issue is fixed on your side as well with the latest beta build?
Thank you in advance!

Comment 14

[Asif Youssuff]

Cristian, this looks fixed for me in the latest beta.

Comment 15

[Cristian Fogel [:cfogel]]

Thanks again, updating the status for this.