Closed Bug 1586004 Opened 5 years ago Closed 5 years ago

[wpt-sync] Sync PR 19491 - [LayoutNG] Fix bidi reordering of lines with empty inline boxes

Categories

(Core :: CSS Parsing and Computation, task, P4)

Product:
Core
Component:
CSS Parsing and Computation
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla71
Tracking Flags:
Tracking Status
firefox71 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 19491 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/19491
Details from upstream follow.

Koji Ishii <kojii@chromium.org> wrote:

[LayoutNG] Fix bidi reordering of lines with empty inline boxes

This patch fixes bidi reordering sometimes confused by empty
inline boxes.

These items do not have resolved bidi levels. Before this
patch, |NGInlineLayoutAlgorithm| reordered ignoring such
items. This patch changes it to assign bidi levels to such
items by copying from adjacent items and let reordering to
handle them.

Bug: 1010662, 998872
Change-Id: I5d074143970b83b64bddbb83cd03b17551e3f521

Reviewed-on: https://chromium-review.googlesource.com/1837435
WPT-Export-Revision: 664f4c07c7ac25e52d17af91ff04a8c1810ec282

Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Ran 2 tests
PASS   : 2
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0f383200b32d
[wpt PR 19491] - [LayoutNG] Fix bidi reordering of lines with empty inline boxes, a=testonly

https://hg.mozilla.org/mozilla-central/rev/0f383200b32d

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox71: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla71
You need to log in before you can comment on or make changes to this bug.