It's not a good idea to refer to NS_DIALOGPARAMBLOCK_CONTRACTID using the hardcoded "@mozilla.org/embedcomp/dialogparam;1". First, the code style is not good. Second, it is more easy to be wrong using the literal than the placehold. Third, if the literal changed someday, you may need to change it everywhere. Although this may not be easy to happen. See also bug 158080 For convenience bug 154047 Assign to Anto for continuous handling
Created attachment 92864 [details] [diff] [review] V 1.0,please r=? & sr=? Henry could you r=? my patch. Thank you.
Comment on attachment 92864 [details] [diff] [review] V 1.0,please r=? & sr=? Thx, Anto. r=henry
Attachment #92864 - Flags: review+
Comment on attachment 92864 [details] [diff] [review] V 1.0,please r=? & sr=? sr=alecf actually, while you're there can you remove NS_DIALOGPARAMBLOCK_IID ? its not used anywhere and its just confusing :) (no need for an extra patch, sr=alecf already applies)
Attachment #92864 - Flags: superreview+
Created attachment 95225 [details] [diff] [review] patch version 1.01 remove NS_DIALOGPARAMBLOCK_IID
Attachment #92864 - Attachment is obsolete: true
patch checked into trunk
Status: NEW → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → FIXED
Over to depstein for verification
QA Contact: mdunn → depstein
Verified patch checkin against Mozilla 1.2b Mozilla/5.0 (Windows; U; WinNT4.0; en-US; rv:1.2b) Gecko/20021026 build.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.