158608 - replace the hardcode of "@mozilla.org/embedcomp/dialogparam;1" with NS_DIALOGPARAMBLOCK_CONTRACTID

Status: VERIFIED FIXED

(Core Graveyard :: Embedding: APIs, defect)

Description

[Henry Jia]

It's not a good idea to refer to NS_DIALOGPARAMBLOCK_CONTRACTID using the
hardcoded "@mozilla.org/embedcomp/dialogparam;1".

First, the code style is not good.

Second, it is more easy to be wrong using the literal than the placehold.

Third, if the literal changed someday, you may need to change it everywhere.
Although this may not be easy to happen.

See also bug 158080

For convenience bug 154047

Assign to Anto for continuous handling

Comment 1

[Antonio.Xu]

Attachment: V 1.0,please r=? & sr=?

Henry could you r=? my patch. Thank you.

Comment 2

[Henry Jia]

Comment on attachment 92864 [details] [diff] [review]
V 1.0,please r=? & sr=?

Thx, Anto.

r=henry

Comment 3

[Alec Flett]

Comment on attachment 92864 [details] [diff] [review]
V 1.0,please r=? & sr=?

sr=alecf

actually, while you're there can you remove NS_DIALOGPARAMBLOCK_IID ? its not
used anywhere and its just confusing :)
(no need for an extra patch, sr=alecf already applies)

Comment 4

[Antonio.Xu]

Attachment: patch version 1.01

remove NS_DIALOGPARAMBLOCK_IID

Comment 5

[Antonio.Xu]

patch checked into trunk

Comment 6

[Michael Dunn]

Over to depstein for verification

Comment 7

[David Epstein]

Verified patch checkin against Mozilla 1.2b Mozilla/5.0 (Windows; U; WinNT4.0;
en-US; rv:1.2b) Gecko/20021026 build.