replace the hardcode of "@mozilla.org/embedcomp/dialogparam;1" with NS_DIALOGPARAMBLOCK_CONTRACTID

VERIFIED FIXED

Status

()

VERIFIED FIXED
17 years ago
16 years ago

People

(Reporter: Henry.Jia, Assigned: antonio.xu)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

12.78 KB, patch
antonio.xu
: review+
antonio.xu
: superreview+
Details | Diff | Splinter Review
(Reporter)

Description

17 years ago
It's not a good idea to refer to NS_DIALOGPARAMBLOCK_CONTRACTID using the
hardcoded "@mozilla.org/embedcomp/dialogparam;1".

First, the code style is not good.

Second, it is more easy to be wrong using the literal than the placehold.

Third, if the literal changed someday, you may need to change it everywhere.
Although this may not be easy to happen.

See also bug 158080

For convenience bug 154047

Assign to Anto for continuous handling
(Assignee)

Comment 1

17 years ago
Created attachment 92864 [details] [diff] [review]
V 1.0,please r=? & sr=?

Henry could you r=? my patch. Thank you.
(Reporter)

Comment 2

17 years ago
Comment on attachment 92864 [details] [diff] [review]
V 1.0,please r=? & sr=?

Thx, Anto.

r=henry
Attachment #92864 - Flags: review+

Comment 3

17 years ago
Comment on attachment 92864 [details] [diff] [review]
V 1.0,please r=? & sr=?

sr=alecf

actually, while you're there can you remove NS_DIALOGPARAMBLOCK_IID ? its not
used anywhere and its just confusing :)
(no need for an extra patch, sr=alecf already applies)
Attachment #92864 - Flags: superreview+
(Assignee)

Comment 4

17 years ago
Created attachment 95225 [details] [diff] [review]
patch version 1.01

remove NS_DIALOGPARAMBLOCK_IID
Attachment #92864 - Attachment is obsolete: true
(Assignee)

Updated

17 years ago
Attachment #95225 - Flags: superreview+
Attachment #95225 - Flags: review+
(Assignee)

Comment 5

17 years ago
patch checked into trunk
Status: NEW → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED
(Reporter)

Updated

16 years ago
Blocks: 168910

Comment 6

16 years ago
Over to depstein for verification
QA Contact: mdunn → depstein

Comment 7

16 years ago
Verified patch checkin against Mozilla 1.2b Mozilla/5.0 (Windows; U; WinNT4.0;
en-US; rv:1.2b) Gecko/20021026 build.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.