Closed Bug 1586091 Opened 5 months ago Closed 5 months ago

Port Bug 1514926 Convert arrowscrollbox binding to a custom element

Categories

(Thunderbird :: Toolbars and Tabs, task)

task
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 71.0

People

(Reporter: Paenglab, Assigned: Paenglab)

Details

Attachments

(1 file, 1 obsolete file)

No description provided.
Attached patch 1586091-arrowscrollbox.patch (obsolete) — Splinter Review

Port of https://hg.mozilla.org/mozilla-central/rev/45b2d685bc5f

The weird thing is, that it begins to scroll when the mouse is over the arrow buttons and not only when the buttons are clicked. But this happens already with older Dailies, so not introduced by this patch.

Alessandro, when you find why this happens, could you fix it? If not we can file a new bug for this.

Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #9098646 - Flags: review?(alessandro)

Thanks for taking care of this.
I updated the patch to fix the following issues:

  • Dropdown indicator not appearing/disappearing on resize.
  • Drag&Drop not scrolling when hovering over the next/prev buttons.
  • Set the scroll only on click, not over.

Here's a try run to see if we butchered some tests: https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=3a71b1addfed465a9db210e2ccdc2579ec2b2480

Attachment #9098646 - Attachment is obsolete: true
Attachment #9098646 - Flags: review?(alessandro)
Attachment #9098709 - Flags: review?(richard.marti)
Comment on attachment 9098709 [details] [diff] [review]
1586091-arrowscrollbox.patch

I looked at the interdiff and it looks OK to me. I'm landing this now.

Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/78c57b3a917c
Port bug 1514926: Convert the arrowscrollbox binding to a Custom Element. r=aleca DONTBUILD

Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED

Just in case anyone is wondering: I have a green try with all the stuff landed with DONTBUILD:
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=5a5125885a9c6aa5ebc6bfd28fc1bf7cc33baf18

Target Milestone: --- → Thunderbird 71.0
Comment on attachment 9098709 [details] [diff] [review]
1586091-arrowscrollbox.patch

Looks a lot better now, thanks.
Attachment #9098709 - Flags: review?(richard.marti) → review+
You need to log in before you can comment on or make changes to this bug.