158610 - michaelgbackgrounds.com - Photo Gallery Slideshow Gallery Created with FP does not run correctly

Status: VERIFIED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Mike Abbaticchio]

Page is supposed to display 4 thumbnails up top, and clicking on each item
renders a full size version under the the thumbnails.  The four thumbnails are
supplosed to be scrollable via arrows.

Page is incorrectly displayed in that ckicking on any thumbnail only renders the
first graphic, with the size / proportion of the object that is supposed to be
displayed.

Second problem is not thumbnail scrolling does not work, and if there are more
than 4 thumbnails, they are rendered accross the top of th page.

Comment 1

[Phil Schwartau]

Confirming bug with Mozilla trunk build 20020715xx on WinNT
Browser, not engine ---> DOM Level 0


A typical thumbnail on this page is

<a target="_self"     
href="Javascript:fp_ShowImg(document['fpphoto_6931'],'450','589','1376',0);">

<img hspace="10" vspace="5" border="0"
     id="fpphoto_6931" name="fpphoto_6931"         
     src="photogallery/photo1939/Roccoco%201.jpg"
     lowsrc="images/Roccoco%201.jpg"
     width="76" height="100"
     title="Roccoco" align="absmiddle" />
</a>



Note the call to the function fp_ShowImg(document['fpphoto_6931'], etc. etc.)
Inside this function, a variable named "src" is used for the first parameter.

That is, in what follows, |src| = document['fpphoto_6931']
This is point where the large image is set:


         var el = document.getElementById('fpGalleryMainImg_1376');
         el.src = src.lowsrc;


In the JavaScript Debugger, we see that |src| resolves correctly to
the thumbnail image, but |src.lowsrc| is undefined for some reason:

         src
         [HTMLImageElement] [class: HTMLImageElement] {0}
         src.lowsrc
         [void] void


Therefore the large image gets assigned an empty src, and that's
why no image shows up. To test all this without using the Mozilla
JavaScript Debugger, just try this javascript:URL in IE vs. Moz:


javascript: var src = document['fpphoto_6931']; alert('thumbnail.src = ' +  
src.src  +  '\nthumbnail.lowsrc = '  +  src.lowsrc);


IN IE6:
thumbnail.src = 
http://www.michaelgbackgrounds.com/photogallery/photo1939/Roccoco%201.jpg 

thumbnail.lowsrc =
images/Roccoco%201.jpg


IN MOZ:
thumbnail.src = 
http://www.michaelgbackgrounds.com/photogallery/photo1939/Roccoco%201.jpg 

thumbnail.lowsrc =
undefined

Comment 2

[Boris Zbarsky [:bzbarsky]]

lowsrc is not supported.  See bug 92453

Comment 3

[Bob Clary [:bc] (inactive)]

Mike, this site is using frontpage 5 and has the aforementioned problems with
lowsrc. You can contact the site directly at
mailto:[e-mail]?subject=Website Response which will have more effect if
you are a potential customer.

Comment 4

[Mike Kaply [:mkaply]]

doron,

Can you suggest a different way to do this that is as easy as using lowsrc that
we can suggest to the websites?

Thanks

Comment 5

[Tom Williams]

I experience this SAME problem on Tamira Fox's site:  

http://www.tamirafox.com/head_shots.htm

all of her FrontPage generated image galleries behave this way.  The galleries
work FINE in Netscape 4.77 and Opera 7.11 on Linux.  It mis-behaves with Mozilla
2003052309 on Linux.

Peace...

Comment 6

[Mike Kaply [:mkaply]]

Attachment: Implement lowsrc attribute

This patch implements the setting and querying of the lowsrc attribute to allow
these sites to work.

It does NOT make lowsrc work, and we have no plans to do that.

Comment 7

[Stuart Parmenter]

r=pavlov

is this ok with you jst?  can you sr=?

Comment 8

[Johnny Stenback (:jst)]

Comment on attachment 124847 [details] [diff] [review]
Implement lowsrc attribute

sr=jst

Comment 9

[Mike Kaply [:mkaply]]

Moving to code

Comment 10

[Mike Kaply [:mkaply]]

Marking blocking 1.4.

Fix is in hand. We get a lot of bugs where frontpage galleries don't work.

This makes them work VERY low risk.

Just adding support for lowsrc query/set in the DOM.

Comment 11

[Brendan Eich [:brendan]]

Comment on attachment 124847 [details] [diff] [review]
Implement lowsrc attribute

Marking r= and sr= for pavlov and jst, and approving for 1.4.

/be

Comment 12

[Mike Kaply [:mkaply]]

Fixed on trunk and branch.

Comment 13

[Andrew Schultz]

*** Bug 189217 has been marked as a duplicate of this bug. ***

Comment 14

[Ninoschka Baca]

Trunk and branch build 2003-06-12: Win2k

1. The page displays 4 thumbnails up top - ok.
2. After clicking on each item, it renders a full size version under the
thumbnails - ok.
3. The four thumbnails are supposed to be scrollable via arrows - I don't see
the arrows. If this is related to the lowsrc issue and is not intended to be
present then this bug can be verified as fixed.

If no comments appear to the contrary then I will mark this as verified/fixed on
6/13.

Comment 15

[Ninoschka Baca]

Verified Fixed.