1586100 - Spidermonkey build failure with --enable-clang-plugin: No rule to make target 'js/src/export', needed by 'build/clang-plugin/tests/target-objects'.

Status: RESOLVED FIXED

(Developer Infrastructure :: Source Code Analysis, defect, P3)

Description

[Matthew Gaudet (he/him) [:mgaudet]]

STR:

1. Checkout central (or 001e665b6b2c at time of writing)
2. mkdir js/src/build_clang_format_DBG.OBJ; cd js/src/build_clang_format_DBG.OBJ
3. ../configure --enable-clang-plugin
4. make

Expected result: Build succeeds and clang plugin detects errors if any.

Actual Result:

matthew@xtower:~/unified/js/src/build_clang_plugin_DBG.OBJ$ make
make[1]: Entering directory '/home/matthew/unified/js/src/build_clang_plugin_DBG.OBJ'
make recurse_pre-export
make[2]: Entering directory '/home/matthew/unified/js/src/build_clang_plugin_DBG.OBJ'
/home/matthew/unified/js/src/build_clang_plugin_DBG.OBJ/_virtualenvs/init/bin/python -m mozbuild.action.process_install_manifest --track install_dist_include.track dist/include _build_manifests/install/dist_include
Elapsed: 0.02s; From dist/include: Kept 406 existing; Added/updated 0; Removed 0 files and 0 directories.
/home/matthew/unified/js/src/build_clang_plugin_DBG.OBJ/_virtualenvs/init/bin/python -m mozbuild.action.process_install_manifest --track install_dist_public.track dist/public _build_manifests/install/dist_public
Elapsed: 0.00s; From dist/public: Kept 0 existing; Added/updated 0; Removed 0 files and 0 directories.
/home/matthew/unified/js/src/build_clang_plugin_DBG.OBJ/_virtualenvs/init/bin/python -m mozbuild.action.process_install_manifest --track install_dist_private.track dist/private _build_manifests/install/dist_private
Elapsed: 0.00s; From dist/private: Kept 0 existing; Added/updated 0; Removed 0 files and 0 directories.
/home/matthew/unified/js/src/build_clang_plugin_DBG.OBJ/_virtualenvs/init/bin/python -m mozbuild.action.process_install_manifest --track install__tests.track _tests _build_manifests/install/_tests
Elapsed: 0.03s; From _tests: Kept 489 existing; Added/updated 0; Removed 0 files and 0 directories.
/home/matthew/unified/js/src/build_clang_plugin_DBG.OBJ/_virtualenvs/init/bin/python -m mozbuild.action.process_install_manifest --track install_dist_bin.track dist/bin _build_manifests/install/dist_bin
Elapsed: 0.00s; From dist/bin: Kept 1 existing; Added/updated 0; Removed 0 files and 0 directories.
make[2]: Leaving directory '/home/matthew/unified/js/src/build_clang_plugin_DBG.OBJ'
make[1]: Leaving directory '/home/matthew/unified/js/src/build_clang_plugin_DBG.OBJ'
make[1]: Entering directory '/home/matthew/unified/js/src/build_clang_plugin_DBG.OBJ'
make recurse_export
make[2]: Entering directory '/home/matthew/unified/js/src/build_clang_plugin_DBG.OBJ'
make[3]: Entering directory '/home/matthew/unified/js/src/build_clang_plugin_DBG.OBJ/build/clang-plugin'
make[3]: Nothing to be done for 'host-objects'.
make[3]: Leaving directory '/home/matthew/unified/js/src/build_clang_plugin_DBG.OBJ/build/clang-plugin'
make[2]: Circular build/clang-plugin/host <- config/export dependency dropped.
make[3]: Entering directory '/home/matthew/unified/js/src/build_clang_plugin_DBG.OBJ/build/clang-plugin'
make[3]: Nothing to be done for 'host'.
make[3]: Leaving directory '/home/matthew/unified/js/src/build_clang_plugin_DBG.OBJ/build/clang-plugin'
make[2]: Circular js/src/export <- config/export dependency dropped.
make[2]: Circular js/src/export <- config/host dependency dropped.
make[3]: Entering directory '/home/matthew/unified/js/src/build_clang_plugin_DBG.OBJ/js/src'
make[3]: Nothing to be done for 'export'.
make[3]: Leaving directory '/home/matthew/unified/js/src/build_clang_plugin_DBG.OBJ/js/src'
make[3]: Entering directory '/home/matthew/unified/js/src/build_clang_plugin_DBG.OBJ/build/clang-plugin/tests'

<snipped test files building> 

make recurse_compile
make[2]: Entering directory '/home/matthew/unified/js/src/build_clang_plugin_DBG.OBJ'
make[3]: Entering directory '/home/matthew/unified/js/src/build_clang_plugin_DBG.OBJ/build/clang-plugin'
make[3]: Nothing to be done for 'host-objects'.
make[3]: Leaving directory '/home/matthew/unified/js/src/build_clang_plugin_DBG.OBJ/build/clang-plugin'
make[3]: Entering directory '/home/matthew/unified/js/src/build_clang_plugin_DBG.OBJ/build/clang-plugin'
make[3]: Nothing to be done for 'host'.
make[3]: Leaving directory '/home/matthew/unified/js/src/build_clang_plugin_DBG.OBJ/build/clang-plugin'
make[2]: *** No rule to make target 'js/src/export', needed by 'build/clang-plugin/tests/target-objects'.  Stop.
make[2]: Leaving directory '/home/matthew/unified/js/src/build_clang_plugin_DBG.OBJ'
/home/matthew/unified/config/recurse.mk:32: recipe for target 'compile' failed
make[1]: *** [compile] Error 2
make[1]: Leaving directory '/home/matthew/unified/js/src/build_clang_plugin_DBG.OBJ'
/home/matthew/unified/config/rules.mk:389: recipe for target 'default' failed
make: *** [default] Error 2

Not sure what the deal is with the circular dependency warnings, but they seem key to this failure.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The priority flag is not set for this bug.
:Sylvestre, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 2

[Sylvestre Ledru [:Sylvestre]]

Not sure it is indeed supported.

Comment 3

[Matthew Gaudet (he/him) [:mgaudet]]

Oh, this also fails with mach based building of JS:

Mozconfig:

ac_add_options --enable-application=js
ac_add_options --enable-clang-plugin

produces the same error.

Comment 4

[Sylvestre Ledru [:Sylvestre]]

Is it blocking you? Thanks

Comment 5

[Matthew Gaudet (he/him) [:mgaudet]]

No, the priority seems right. It would be nice to have working, because I shell build about 10-50x as often as I do a browser build, but I know I'm in the minority.

Comment 6

[Matthew Gaudet (he/him) [:mgaudet]]

I would say though, for JS devs, it would reduce backouts: Just got backed out in Bug 1580338 for the "explicit" required check, which is checked by static analysis, and would be prevented by being able to add --clang-plugin to shell only builds (which we could then do in treeherder for people using things like mach try --preset=sm-shell )

Comment 7

[Matthew Gaudet (he/him) [:mgaudet]]

Just built the browser with --enable-clang-plugin, and noticed the circular dependency message is also emitted:

0:01.55 make[3]: Circular build/clang-plugin/host <- config/export dependency dropped.

Comment 8

[Mike Hommey [:glandium]]

Attachment: Bug 1586100 - Avoid circular dependencies related to config/export|host.

Comment 9

[Mike Hommey [:glandium]]

Attachment: Bug 1586100 - Only depend on js/src/export when it is available.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5c88ec5a98a6
Avoid circular dependencies related to config/export|host. r=dmajor
https://hg.mozilla.org/integration/autoland/rev/4ab85fb8f492
Only depend on js/src/export when it is available. r=dmajor

Comment 11

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/5c88ec5a98a6
https://hg.mozilla.org/mozilla-central/rev/4ab85fb8f492