1586111 - Update-Verify fails on Thunderbird beta: ACCEPTED_MAR_CHANNEL_ID

Status: RESOLVED FIXED

(Thunderbird :: Build Config, defect)

Description

[Rob Lemley [:rjl]]

This consistently occurs on beta releases. It's a configuration problem.

Difference found in update-settings.ini
update-settings.ini still differs after transforms, residual diff:
-ACCEPTED_MAR_CHANNEL_IDS=thunderbird-comm-beta,thunderbird-comm-release
+ACCEPTED_MAR_CHANNEL_IDS=thunderbird-comm-beta
TEST-UNEXPECTED-FAIL: differences found after update
TEST-UNEXPECTED-FAIL: [69.0 de complete] check_updates returned failure for Linux_x86_64-gcc3 downloads/thunderbird-69.0b3.tar.bz2 vs. downloads/thunderbird-70.0b3.tar.bz2: 1

The fix needs to go in comm/taskcluster/ci/build/kind.yml. Add "thunderbird-comm-release" to "accepted-mar-channel-ids" for release-type "beta". Firefox has their configured that way.

Comment 1

[Rob Lemley [:rjl]]

Attachment: bug_1586111.patch

Fixes a long standing bug on beta releases with Update Verify tests.
The updated string finds its way to a step that looks at the results of
a directory diff. update-settings.ini does have both -beta and -release
in it, so verification fails because it's only expecting -beta.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/d5a91d48099b
Update-verify test fix for beta builds. r=darktrojan

Comment 3

[Jorg K (CEST = GMT+2)]

Uplift to beta, right?

Comment 4

[Rob Lemley [:rjl]]

Comment on attachment 9099063 [details] [diff] [review]
bug_1586111.patch

[Approval Request Comment]
Regression caused by (bug #): unknown,
User impact if declined: none
Testing completed (on c-c, etc.): 
Risk to taking this patch (and alternatives if risky):
There is no end-user impact if this doesn't work out for any reason. The fix only affects how the differences between two install directories are processed.

Comment 5

[Jorg K (CEST = GMT+2)]

Comment on attachment 9099063 [details] [diff] [review]
bug_1586111.patch

In general, you don't need to fill in the approval request details ;-)

Comment 6

[Jorg K (CEST = GMT+2)]

TB 70 beta 4:
https://hg.mozilla.org/releases/comm-beta/rev/62fcda841f60fab2ba5e83854058b25a7cd813aa