Closed Bug 1586139 Opened 2 months ago Closed 18 days ago

Fix reader mode browser chrome tests so they pass with fission enabled

Categories

(Toolkit :: Reader Mode, defect, P1)

defect

Tracking

()

RESOLVED FIXED
mozilla72
Fission Milestone M4.1
Tracking Status
firefox72 --- fixed

People

(Reporter: Gijs, Assigned: Gijs)

References

(Blocks 1 open bug)

Details

Attachments

(3 files)

It's unclear why these tests fail; reader mode shouldn't really need fission work (I hope?)

This seems to be due to the use of event listening in the content frame; the use of BrowserTestUtils.waitForContentEvent in 5 of the 6 tests is broken in fission, possibly because we process-switch and end up with the listener in the "wrong" process, before that switch occurs.

The other test, browser_readerMode_hidden_nodes.js, manually adds DOMContentLoaded and MozAfterPaint handlers, and other tests in the fission spreadsheet also list having problems with this - potentially due to a similar issue of adding the listeners too late or too early.

This needs a "proper" way to wait for custom/untrusted content events to fix.

Assignee: gijskruitbosch+bugs → nobody
Status: ASSIGNED → NEW
Depends on: 1586393
Depends on: 1588193
No longer depends on: 1586393
Fission Milestone: --- → M4.1
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Blocks: 1591469
Pushed by rgurzau@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/adfdc1b55325
enable reader mode tests in fission, r=mccr8

(In reply to Pulsebot from comment #4)

Pushed by rgurzau@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/adfdc1b55325
enable reader mode tests in fission, r=mccr8

Why was this pushed? The trypush has one of the tests perma-orange on windows-10-64-qr ( https://treeherder.mozilla.org/#/jobs?repo=try&revision=e72b0953d8021901b456cc741290b97d504ea081 ). I was intending to look into it next week, I kind of have a lot on my plate at the moment so I didn't get to it...

I expect you probably want to disable browser_readerMode.js on windows+fission for now...

Flags: needinfo?(rgurzau)

Looked over on the try push and did some more retriggers there on windows-10-64-qr as i see only one failure for browser_readerMode.js. Will wait for them to finish to see if it's just high-frequency or perma failure indeed and if the disable on that test is needed. Thank you.

Flags: needinfo?(rgurzau)

(In reply to Raul Gurzau (:RaulG) from comment #6)

Looked over on the try push and did some more retriggers there on windows-10-64-qr as i see only one failure for browser_readerMode.js.

It's orange on every one of the bc2 jobs that have finished at this point on https://treeherder.mozilla.org/#/jobs?repo=try&revision=e72b0953d8021901b456cc741290b97d504ea081&selectedJob=276436013 - it's below the failure of browser/components/sessionstore/test/browser_windowStateContainer.js on 4 of the 5 failing jobs.

(In reply to Raul Gurzau (:RaulG) from comment #9)

Disabled browser_readerMode.js and another test on linux as on Try it seems to fail: https://treeherder.mozilla.org/#/jobs?repo=try&group_state=expanded&selectedJob=276434280&revision=e72b0953d8021901b456cc741290b97d504ea081

As noted on phab, this commit ( https://hg.mozilla.org/integration/autoland/rev/adfdc1b55325 ) only changed reader mode test files. There's no way it's got anything to do with the scrollPositions.js failure.

Attachment #9109278 - Attachment description: Bug 1586139 - Disabled browser_scrollPositions.js on linux with fission and browser_readerMode.js on windows with fission. r=Gijs → Bug 1586139 - Disabled browser_readerMode.js on windows with fission. r=Gijs
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/16aae9e3e3ea
Disabled browser_readerMode.js on windows with fission. r=Gijs
Keywords: leave-open
Attachment #9110211 - Attachment description: Bug 1586139 - fix race condition in reader mode test, r?mccr8 → Bug 1586139 - fix race condition in reader mode test, r?kmag
Keywords: leave-open
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/3d2ddf81f801
fix race condition in reader mode test, r=kmag
Status: ASSIGNED → RESOLVED
Closed: 18 days ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla72
You need to log in before you can comment on or make changes to this bug.