Closed Bug 1586232 Opened 5 years ago Closed 5 years ago

Animate the megabar with transforms only

Categories

(Firefox :: Address Bar, enhancement, P1)

Product:
Firefox
Component:
Address Bar
Type:
enhancement
Points:
5

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 71
Iteration:
71.3 - Sept 30 - Oct 13
Tracking Flags:
Tracking Status
firefox71 --- fixed

People

(Reporter: dao, Assigned: dao)

References

Details

(Keywords: perf)

Attachments

(1 file)

Bug 1586232 - Animate the megabar with transforms only
47 bytes, text/x-phabricator-request
Details | Review

I have a prototype patch that replaces the width + padding animation with a transform one, which should perform better. The downside is that the contents of the address bar animate as well. I'm not sure if we'd be willing to accept that effect or could somehow prevent it.

Assignee: nobody → dao+bmo
Blocks: 1586112
Iteration: --- → 71.3 - Sept 30 - Oct 13
Points: --- → 5
Priority: P2 → P1

I'm now fairly confident that this is feasible.

Summary: Investigate animating the megabar with transforms only → Animate the megabar with transforms only
Attachment #9098784 - Attachment description: Bug 1586232 - Prototype patch → Bug 1586232 - Animate the megabar with transforms only.
Attachment #9098784 - Attachment description: Bug 1586232 - Animate the megabar with transforms only. → Bug 1586232 - Prototype patch
Attachment #9098784 - Attachment description: Bug 1586232 - Prototype patch → Bug 1586232 - Animate the megabar with transforms only.
Attachment #9098784 - Attachment description: Bug 1586232 - Animate the megabar with transforms only. → Bug 1586232 - Prototype patch
Attachment #9098784 - Attachment description: Bug 1586232 - Prototype patch → Bug 1586232 - Animate the megabar with transforms only
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8cdc2f617b0d
Animate the megabar with transforms only r=mak
Backout by rgurzau@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4ed02097c793
Backed out changeset 8cdc2f617b0d fpr faiures at browser_searchbar_openpopup.js on a CLOSED TREE.

Backed out changeset 8cdc2f617b0d (bug 1586232) fpr faiures at browser_searchbar_openpopup.js on a CLOSED TREE.

Backout link: https://hg.mozilla.org/integration/autoland/rev/4ed02097c793f824e312416ed5ef8ddb626fc3fa

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&revision=8cdc2f617b0da7d3a52b98ebcddc250f75fccb48&selectedJob=269831040

Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=269825608&repo=autoland&lineNumber=20762

Log snippet:

[task 2019-10-04T19:27:16.027Z] 19:27:16 INFO - Entering test open_icon_context
[task 2019-10-04T19:27:16.027Z] 19:27:16 INFO - TEST-PASS | browser/components/search/test/browser/browser_searchbar_openpopup.js | Shouldn't have seen the suggestions popup -
[task 2019-10-04T19:27:16.027Z] 19:27:16 INFO - Leaving test open_icon_context
[task 2019-10-04T19:27:16.027Z] 19:27:16 INFO - Leaving test bound
[task 2019-10-04T19:27:16.027Z] 19:27:16 INFO - Entering test bound open_empty
[task 2019-10-04T19:27:16.027Z] 19:27:16 INFO - Clicking icon
[task 2019-10-04T19:27:16.027Z] 19:27:16 INFO - Buffered messages finished
[task 2019-10-04T19:27:16.027Z] 19:27:16 INFO - TEST-UNEXPECTED-FAIL | browser/components/search/test/browser/browser_searchbar_openpopup.js | Test timed out -
[task 2019-10-04T19:27:16.028Z] 19:27:16 INFO - GECKO(1865) | [Child 1867, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80070057: file /builds/worker/workspace/build/src/dom/base/ThirdPartyUtil.cpp, line 217
[task 2019-10-04T19:27:16.028Z] 19:27:16 INFO - Search engine removed: testEngine.xml
[task 2019-10-04T19:27:16.028Z] 19:27:16 INFO - GECKO(1865) | [Child 1867, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80070057: file /builds/worker/workspace/build/src/dom/base/ThirdPartyUtil.cpp, line 217
[task 2019-10-04T19:27:16.028Z] 19:27:16 INFO - GECKO(1865) | [Child 1867, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80070057: file /builds/worker/workspace/build/src/dom/base/ThirdPartyUtil.cpp, line 217
[task 2019-10-04T19:27:16.028Z] 19:27:16 INFO - GECKO(1865) | MEMORY STAT | vsize 7733MB | residentFast 415MB | heapAllocated 98MB
[task 2019-10-04T19:27:16.028Z] 19:27:16 INFO - TEST-OK | browser/components/search/test/browser/browser_searchbar_openpopup.js | took 90252ms
[task 2019-10-04T19:27:16.029Z] 19:27:16 INFO - GECKO(1865) | ++DOCSHELL 0x1156da800 == 1 [pid = 1868] [id = {0e0f7329-9270-ec42-a185-585ea7b470bb}]
[task 2019-10-04T19:27:16.029Z] 19:27:16 INFO - GECKO(1865) | ++DOMWINDOW == 1 (0x115726020) [pid = 1868] [serial = 58] [outer = 0x0]
[task 2019-10-04T19:27:16.029Z] 19:27:16 INFO - GECKO(1865) | ++DOMWINDOW == 2 (0x115675c00) [pid = 1868] [serial = 59] [outer = 0x115726020]
[task 2019-10-04T19:27:16.029Z] 19:27:16 INFO - GECKO(1865) | ++DOMWINDOW == 3 (0x11567d000) [pid = 1868] [serial = 60] [outer = 0x115726020]
[task 2019-10-04T19:27:16.072Z] 19:27:16 INFO - checking window state
[task 2019-10-04T19:27:16.169Z] 19:27:16 INFO - TEST-START | browser/components/search/test/browser/browser_searchbar_smallpanel_keyboard_navigation.js
[task 2019-10-04T19:27:16.436Z] 19:27:16 INFO - GECKO(1865) | [Child 1867, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80070057: file /builds/worker/workspace/build/src/dom/base/ThirdPartyUtil.cpp, line 217
[task 2019-10-04T19:27:16.468Z] 19:27:16 INFO - GECKO(1865) | [Child 1867, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80070057: file /builds/worker/workspace/build/src/dom/base/ThirdPartyUtil.cpp, line 217
[task 2019-10-04T19:27:16.501Z] 19:27:16 INFO - GECKO(1865) | [Child 1867, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80070057: file /builds/worker/workspace/build/src/dom/base/ThirdPartyUtil.cpp, line 217
[task 2019-10-04T19:27:16.501Z] 19:27:16 INFO - GECKO(1865) | [Child 1867, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80070057: file /builds/worker/workspace/build/src/dom/base/ThirdPartyUtil.cpp, line 217
[task 2019-10-04T19:27:16.534Z] 19:27:16 INFO - GECKO(1865) | [Child 1867, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80070057: file /builds/worker/workspace/build/src/dom/base/ThirdPartyUtil.cpp, line 217
[task 2019-10-04T19:27:16.638Z] 19:27:16 INFO - Not taking screenshot here: see the one that was previously logged
[task 2019-10-04T19:27:16.638Z] 19:27:16 INFO - Buffered messages logged at 19:27:16
[task 2019-10-04T19:27:16.638Z] 19:27:16 INFO - Entering test bound init
[task 2019-10-04T19:27:16.638Z] 19:27:16 INFO - Waiting for engine to be added: testEngine.xml
[task 2019-10-04T19:27:16.638Z] 19:27:16 INFO - Search engine added: testEngine.xml
[task 2019-10-04T19:27:16.638Z] 19:27:16 INFO - cleanup the search history
[task 2019-10-04T19:27:16.639Z] 19:27:16 INFO - adding search history values: foo1,foo2,foo3
[task 2019-10-04T19:27:16.639Z] 19:27:16 INFO - Leaving test bound init
[task 2019-10-04T19:27:16.639Z] 19:27:16 INFO - Entering test bound test_arrows
[task 2019-10-04T19:27:16.639Z] 19:27:16 INFO - Opening search panel
[task 2019-10-04T19:27:16.639Z] 19:27:16 INFO - Buffered messages finished

Flags: needinfo?(dao+bmo)
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/92802cb27d03
Animate the megabar with transforms only r=mak
Flags: needinfo?(dao+bmo)

https://hg.mozilla.org/mozilla-central/rev/92802cb27d03

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox71: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 71
Keywords: perf
Regressions: 1586514
No longer regressions: 1586530
No longer regressions: 1586531
Blocks: 1586542
Regressions: 1584350

== Change summary for alert #23367 (as of Mon, 07 Oct 2019 10:42:17 GMT) ==

Improvements:

41% tart macosx1014-64-shippable opt e10s stylo 7.68 -> 4.50
35% tart windows10-64-shippable opt e10s stylo 3.38 -> 2.19
35% tart windows10-64-shippable opt e10s stylo 3.36 -> 2.19
34% tart windows7-32-shippable opt e10s stylo 3.33 -> 2.20
33% tart windows7-32-shippable opt e10s stylo 3.37 -> 2.25
28% tart linux64-shippable opt e10s stylo 2.63 -> 1.90

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=23367

Regressions: 1586778
Blocks: 1585954
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: