1586262 - run-task may not log the entire contents of a long line of task output

Status: RESOLVED FIXED

(Firefox Build System :: Task Configuration, task, P1)

Description

[Geoff Brown [:gbrown]]

run-task does not check the return value of write() at:

https://searchfox.org/mozilla-central/rev/01d1011ca4a460f751da030d455d35c267c3e210/taskcluster/scripts/run-task#106

If less than the full requested buffer is written, the remainder is discarded.

I suspect this is the cause of bug 1567638.

Comment 1

[Geoff Brown [:gbrown]]

https://treeherder.mozilla.org/#/jobs?repo=try&tier=1%2C2%2C3&revision=80d561d084611e5db5768f26236e11869386e68f

demonstrates the issue by writing very long (20000 character) lines of output from the task: write() often reports writing less than requested, and the effect is evident in the log output.

Comment 2

[Geoff Brown [:gbrown]]

https://treeherder.mozilla.org/#/jobs?repo=try&tier=1%2C2%2C3&revision=2e78670b8cf6b3dd2288d8112c3d4cceed1bfb4b

demonstrates a solution, again using very long lines of task output.

Comment 3

[Geoff Brown [:gbrown]]

Attachment: Bug 1586262 - Ensure run-task logs very long task output lines; r=

Check the return code of write() to determine if the output line has actually
been written completely; if not, write the remainder.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bcfc1146667c
Ensure run-task logs very long task output lines; r=dustin

Comment 5

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/bcfc1146667c