LSNG: Finish RequestHelper when LSRequestChild actor is unexpectedly destroyed
Categories
(Core :: Storage: localStorage & sessionStorage, defect, P1)
Tracking
()
People
(Reporter: janv, Assigned: janv)
References
(Blocks 1 open bug)
Details
Crash Data
Attachments
(1 file)
47 bytes,
text/x-phabricator-request
|
lizzard
:
approval-mozilla-beta+
|
Details | Review |
Assignee | ||
Comment 1•5 years ago
|
||
If LSRequestChild actor is unexpectedly destroyed, the nested event loop runs
until the timer fires. This patch improves that by calling the callback in
LSRequestChild::ActorDestroyed which immediatelly finishes RequestHelper and
finishes the nested event loop in the end too.
Assignee | ||
Comment 2•5 years ago
•
|
||
The current empty ActorDestroy impl can cause a shutdown hang in theory, but I'm not sure about that.
Anyway, it's better to fix it.
Pushed by jvarga@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/88bfb2e60180 LSNG: Finish RequestHelper when LSRequestChild actor is unexpectedly destroyed; r=asuth
Comment 4•5 years ago
|
||
bugherder |
Assignee | ||
Comment 5•5 years ago
|
||
Comment on attachment 9098866 [details]
Bug 1586315 - LSNG: Finish RequestHelper when LSRequestChild actor is unexpectedly destroyed; r=asuth
Beta/Release Uplift Approval Request
- User impact if declined: This patch may help with reducing shutdown hangs. Even if doesn't reduce shutdown hangs, it improves correctness when IPC is unexpectedly disconnected.
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Relatively simple patch, landed 2 days ago on Nightly, no regressions so far.
- String changes made/needed: None
Comment 6•5 years ago
|
||
Comment on attachment 9098866 [details]
Bug 1586315 - LSNG: Finish RequestHelper when LSRequestChild actor is unexpectedly destroyed; r=asuth
Reducing shutdown hangs sounds promising. Maybe just a bit scary.
Let's uplift for beta 14.
Comment 7•5 years ago
|
||
bugherder uplift |
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Updated•5 years ago
|
Description
•