1586403 - [wpt-sync] Sync PR 19527 - Change text directive to text=

Status: RESOLVED FIXED

(Testing :: web-platform-tests, task, P4)

Description

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 19527 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/19527
Details from upstream follow.

Nick Burris <[e-mail]> wrote:

Change text directive to text=

Change the targetText= directive to text=. Also remove the
non-fragment-directive case and the ## delimiter since we definitely
won't be using them.

Updated all tests to use :~:text= syntax.

Updated web platform tests to reflect text= change and delimiter change
to :~:. Tested updated WPT locally with
run_web_tests.py --additional-driver-flag=
'--enable-blink-features=TextFragmentIdentifiers'

Bug: 1008874
Change-Id: Ic7f3db39e0a17d5adb8186b2ab5081d60553bd8d

Reviewed-on: https://chromium-review.googlesource.com/1835892
WPT-Export-Revision: 1ee6375fac5e46df5c6b1d9917be686ca27c4e2f

Comment 1

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=63f89cc7698acd64009b82f0c9d9bbe06c3a33c1

Comment 2

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=2c9dc372f5d073442928623e2946449bc05e67cb

Comment 3

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=fa80cd945fd35387b95718d2afdee1ca4274d126

Comment 4

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

## GitHub CI Results
wpt.fyi [PR Results](https://wpt.fyi/results/?sha=caed9353b9c2bba7e3df9ec4ecd4d7303ca424e5&label=pr_head) [Base Results](https://wpt.fyi/results/?sha=caed9353b9c2bba7e3df9ec4ecd4d7303ca424e5&label=pr_base)

Ran 1 tests and 28 subtests

### Firefox
  OK     : 1
  PASS   : 4
  FAIL   : 11

### Chrome
  PASS   : 2
  FAIL   : 5
  TIMEOUT: 2
  NOTRUN : 7

### Safari
  OK     : 1
  FAIL   : 15

### Existing tests that now have a worse result

/scroll-to-text-fragment/scroll-to-text-fragment.html
   Test navigation with text fragment anchor ##targetText=this-,is,page,-none: Firefox: PASS->MISSING, Chrome: TIMEOUT->MISSING, Safari: FAIL->MISSING
   Test navigation with text fragment anchor ##targetText=tes&targetText=age: Firefox: PASS->MISSING, Chrome: NOTRUN->MISSING, Safari: FAIL->MISSING
   Test navigation with text fragment anchor #pagestate##targetText=nomatch: Firefox: PASS->MISSING, Chrome: NOTRUN->MISSING, Safari: FAIL->MISSING

### Other new tests that's don't pass

/scroll-to-text-fragment/scroll-to-text-fragment.html
   Test navigation with text fragment anchor #:~:text=this,test,-page: Firefox: FAIL, Chrome: TIMEOUT, Safari: FAIL
   Test navigation with text fragment anchor #:~:text=test: Firefox: FAIL, Chrome: FAIL, Safari: FAIL
   Test navigation with text fragment anchor #:~:text=this%20is%20a%20test%20page: Firefox: FAIL, Chrome: NOTRUN, Safari: FAIL
   Test navigation with text fragment anchor #element:~:text=nomatch: Firefox: FAIL, Chrome: NOTRUN, Safari: FAIL
   Test navigation with text fragment anchor #:~:text=this,page: Firefox: FAIL, Chrome: FAIL, Safari: FAIL
   Test navigation with text fragment anchor #pagestate:~:text=test: Firefox: FAIL, Chrome: NOTRUN, Safari: FAIL
   Test navigation with text fragment anchor #:~:text=this-,is,test,-page: Firefox: FAIL, Chrome: FAIL, Safari: FAIL
   Test navigation with text fragment anchor #:~:text=this-,is,test: Firefox: FAIL, Chrome: FAIL, Safari: FAIL
   Test navigation with text fragment anchor #element:~:directive: Firefox: FAIL, Chrome: NOTRUN, Safari: FAIL
   Test navigation with text fragment anchor #:~:text=this&text=test,page: Firefox: FAIL, Chrome: NOTRUN, Safari: FAIL

## Gecko CI Results

Ran 1 tests and 15 subtests
  OK     : 1
  PASS   : 4
  FAIL   : 11

### New tests that don't pass
/scroll-to-text-fragment/scroll-to-text-fragment.html
  Test navigation with text fragment anchor #:~:text=test: FAIL
  Test navigation with text fragment anchor #:~:text=this%20is%20a%20test%20page: FAIL
  Test navigation with text fragment anchor #:~:text=this&text=test,page: FAIL
  Test navigation with text fragment anchor #:~:text=this,page: FAIL
  Test navigation with text fragment anchor #:~:text=this,test,-page: FAIL
  Test navigation with text fragment anchor #:~:text=this-,is,test: FAIL
  Test navigation with text fragment anchor #:~:text=this-,is,test,-page: FAIL
  Test navigation with text fragment anchor #element:~:directive: FAIL
  Test navigation with text fragment anchor #element:~:text=nomatch: FAIL
  Test navigation with text fragment anchor #pagestate:~:text=test: FAIL

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9c8a9b8d3633
[wpt PR 19527] - Change text directive to text=, a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/22046ec06bdf
[wpt PR 19527] - Update wpt metadata, a=testonly

Comment 6

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/9c8a9b8d3633
https://hg.mozilla.org/mozilla-central/rev/22046ec06bdf