Closed Bug 1586613 Opened 5 months ago Closed 5 months ago

File msgFolderPickerOverlay.js is unneded in Thunderbird

Categories

(MailNews Core :: Backend, task)

task
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 71.0

People

(Reporter: aceman, Assigned: aceman)

Details

Attachments

(1 file)

The file msgFolderPickerOverlay.js is only loaded from msgFolderPickerOverlay.xul which only exists in Seamonkey (suite). But msgFolderPickerOverlay.js is stored in /mailnews and is also shipped with Thunderbird.
It seems pointless to ship an unused file.

Attached patch 1586613.patchSplinter Review

I suggest to move the file to suite/, next to the msgFolderPickerOverlay.xul file.

Try run:
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=a1fa66ec0cbc5ecf8f9beadac736f26379092cd3

Attachment #9099103 - Flags: review?(jorgk)
Attachment #9099103 - Flags: review?(frgrahl)
Comment on attachment 9099103 [details] [diff] [review]
1586613.patch

Thanks for keeping track of what isn't used any more.
Attachment #9099103 - Flags: review?(jorgk) → review+
Comment on attachment 9099103 [details] [diff] [review]
1586613.patch

Looks good to me. Thanks.
Attachment #9099103 - Flags: review?(frgrahl) → review+

I haven't tested it in Seamonkey, maybe the link <script type="application/javascript" src="chrome://messenger/content/msgFolderPickerOverlay.js"/> in msgFolderPickerOverlay.xul needs some change after moving the file?

Keywords: checkin-needed

in msgFolderPickerOverlay.xul needs some change after moving the file?

No worries. The overlay is broken. We are currently bringing SM up to spec one piece at a time. I or IanN will fix it with 2.57.

Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/e7476e934b19
move msgFolderPickerOverlay.js to suite/ as it isn't used in Thunderbird. r=jorgk,frg

Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 71.0
You need to log in before you can comment on or make changes to this bug.