1586647 - lockwise ui is broken in firefox 70.0b12 if identity.fxaccounts.enabled = false

Status: VERIFIED FIXED

(Firefox :: about:logins, defect, P1)

Description

[gitter-me]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:70.0) Gecko/20100101 Firefox/70.0

Steps to reproduce:

In about:config set identity.fxaccounts.enabled = false.
Open about:logins and click on any saved login on the left.

Actual results:

If I disable fxaccounts in about:config, then in the lockwise ui I can click any entry but the content is not loaded in the details pane.

In the devtools I get the following error with stacktrace:

TypeError: state is undefinedfxaccounts-button.js:68:5
updateState chrome://browser/content/aboutlogins/components/fxaccounts-button.js:68
handleSyncState chrome://browser/content/aboutlogins/aboutLogins.js:36
<anonymous> chrome://browser/content/aboutlogins/aboutLogins.js:77
sendToContent resource:///actors/AboutLoginsChild.jsm:244
receiveMessage resource:///actors/AboutLoginsChild.jsm:223
receiveMessage resource://gre/modules/ActorManagerChild.jsm:179

Expected results:

The details pane should load the selected account on the left

Comment 1

[Francesco Lodolo [:flod]]

Confirmed, it's also not possible to create manually a new login, the right part of the window is dead.

[Tracking Requested - why for this release]: unusable UI if fxaccounts are completely disabled.

Comment 2

[Liz Henry (:lizzard) (relman/hg->git project)]

Might be a blocker for skyline.

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1586647 - Hide the Firefox Accounts button if identity.fxaccounts.enabled=false. r?sfoster

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/55dfb08c8dc1
Hide the Firefox Accounts button if identity.fxaccounts.enabled=false. r=sfoster

Comment 5

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/55dfb08c8dc1

Comment 6

[Liz Henry (:lizzard) (relman/hg->git project)]

Can you request uplift? Thanks!
We could try to find someone to verify this today so we can uplift for Thursday morning's build.

Comment 7

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 9099354 [details]
Bug 1586647 - Hide the Firefox Accounts button if identity.fxaccounts.enabled=false. r?sfoster

Beta/Release Uplift Approval Request

• User impact if declined: The about:logins page appears as "broken" if the identity.fxaccounts.enabled pref is set to false.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: In about:config, set the identity.fxaccounts.enabled pref to false.
  Load about:logins
  The Firefox Accounts button at the top right of the page should be hidden if the pref is set to false.
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Covered by automated tests and is minimally invasive.
• String changes made/needed: none

Comment 8

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 9099354 [details]
Bug 1586647 - Hide the Firefox Accounts button if identity.fxaccounts.enabled=false. r?sfoster

Fix for skyline issue, OK for beta 14 uplift.
Let's verify in beta.

Comment 9

[Liz Henry (:lizzard) (relman/hg->git project)]

Verifying in nightly is also useful of course!

Comment 10

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/releases/mozilla-beta/rev/a754727ed64c

Comment 11

[Simona Rosu [:srosu], Ecosystem QA]

I have verified this issue on the latest Nightly 71.0a1 (Build ID: 20191009213914) on Windows 10 x64, Mac 10.14, Ubuntu 16 x64.

• The “Logins & Passwords” page is successfully loaded and all functionalities are working as expected when the “identity.fxaccounts.enabled” pref is set to false.
• Also, the “Sign in to Sync” button is no longer displayed on the “about:logins” page if the “identity.fxaccounts.enabled” pref is set to false.

Comment 12

[Simona Rosu [:srosu], Ecosystem QA]

I have verified this issue on the Firefox Beta 71.0b14 (Build ID: 20191010142853) on Windows 10 x64, Mac 10.14, Ubuntu 16 x64.

• The “Logins & Passwords” page is successfully loaded and all functionalities are working as expected when the “identity.fxaccounts.enabled” pref is set to false.
• Also, the “Sign in to Sync” button is no longer displayed on the “about:logins” page if the “identity.fxaccounts.enabled” pref is set to false.

Comment 13

[Emma Humphries ☕️🎸🧞‍♀️✨ (she/they) [:emceeaich] (Pacific Time) use needinfo]

This bug has been identified as part of a pilot on determining root causes of blocking and dot release drivers.

It needs a root-cause set for it. Please see the list at https://docs.google.com/document/d/1FFEGsmoU8T0N8R9kk-MXWptOPtXXXRRIe4vQo3_HgMw/.

Add the root cause as a whiteboard tag in the form [rca - <cause> ] and remove the rca-needed keyword.

If you have questions, please contact :tmaity.