1586659 - [Protections Panel] Anchor arrow is purple when it's on the bottom

Status: VERIFIED FIXED

(Firefox :: Site Identity, defect, P3)

Description

[(inactive) Nihanth Subramanya [:nhnt11]]

STR:

Move Firefox to the very bottom of the screen and open the panel - it will open above the URL bar rather than below.

In this case, we shouldn't be coloring the arrow purple.

Comment 1

[(inactive) Nihanth Subramanya [:nhnt11]]

Attachment: Bug 1586659 - [Protections Panel] Only color the anchor arrow when it's at the top. r=timhuang,johannh

Comment 2

[(inactive) Nihanth Subramanya [:nhnt11]]

Fortunately this is a cheap fix, but there's a similar issue when Firefox is all the way at the inline-end side of the screen - we should swap the LTR and RTL colors in that case because the arrow gets pushed to the other side. But I don't know how to do this without manually calculating available space and inferring that we need to. There doesn't seem to be an attribute or anything.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ff84a91c8641
[Protections Panel] Only color the anchor arrow when it's at the top. r=johannh

Comment 4

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/ff84a91c8641

Comment 5

[(inactive) Nihanth Subramanya [:nhnt11]]

Comment on attachment 9099136 [details]
Bug 1586659 - [Protections Panel] Only color the anchor arrow when it's at the top. r=timhuang,johannh

Beta/Release Uplift Approval Request

• User impact if declined: Small visual anomaly when Firefox is in the bottom half of the screen - the panel arrow is purple even though it's not part of the header.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Move Firefox towards the bottom of the screen, and open the protections panel - it will open above Firefox due to lack of space below. Without the patch, the arrow of the panel is purple. With the patch, it matches the panel's color.
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Visual polish. Extremely simple CSS change.
• String changes made/needed:

Comment 6

[Cristian Craciun]

Build ID 20191007215350
User Agent Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:71.0) Gecko/20100101 Firefox/71.0

Verified as fixed on the latest Nightly build on Windows 7.

Comment 7

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 9099136 [details]
Bug 1586659 - [Protections Panel] Only color the anchor arrow when it's at the top. r=timhuang,johannh

Minor polish issue, css only, OK for beta 14 uplift.

Comment 8

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/releases/mozilla-beta/rev/ce231a76c7bb

Comment 9

[Cristian Craciun]

Build ID 20191010142853
User Agent Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:70.0) Gecko/20100101 Firefox/70.0

Verified as fixed on the latest Beta build (70.0b14) on Windows 10.