1586666 - [wpt-sync] Sync PR 19542 - [css-lists] Add list-style-type: <string>

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 19542 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/19542
Details from upstream follow.

Oriol Brufau <[e-mail]> wrote:

[css-lists] Add list-style-type: <string>

This patch extends the syntax of the list-style-type property to accept
arbitrary string values in order to customize the marker contents.

I have followed the same approach as https://crrev.com/c/879135 did for
the display property. When a string is specified for list-style-type,
the patch sets it to a special EListStyleType::kString, and the string
is stored in an extra field. As a result of this split, list-style-type
doesn't use as much auto generated code now, e.g. EListStyleType is not
automatically generated.

Intent to Implement and Ship: list-style-type: \<string>
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/GojYpoeDbqc

Spec: https://drafts.csswg.org/css-lists/#valdef-list-style-type-string

Bug: 687946

TEST=third_party/blink/web_tests/external/wpt/css/css-lists/list-style-type-string-001a.html
TEST=third_party/blink/web_tests/external/wpt/css/css-lists/list-style-type-string-001b.html
TEST=third_party/blink/web_tests/external/wpt/css/css-lists/list-style-type-string-002.html
TEST=third_party/blink/web_tests/external/wpt/css/css-lists/parsing/list-style-type-computed.html
TEST=third_party/blink/web_tests/external/wpt/css/css-lists/parsing/list-style-type-valid.html

list-style-type-string-001a and list-style-type-string-001b are imported
from wpt/css/vendor-imports/mozilla/mozilla-central-reftests/lists-3/

Change-Id: I5743b99bc1a8e66679235874623c82650860ea29
Reviewed-on: https://chromium-review.googlesource.com/1841472
WPT-Export-Revision: 05c134855616d4f7aac2c9c989e6d70760f4cc1c

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=989c4b3d44ab13531ddf5c64fe9b06f9c060d35c

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=29f2e390845fe802f44232267568ee9f57d470c2

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=aaa9fa15e87aed95f89b97d003c9bbeac4491a5e

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

## GitHub CI Results
wpt.fyi [PR Results](https://wpt.fyi/results/?sha=3cadaf1de3eff90e6dc53a29d2e2091609dddc69&label=pr_head) [Base Results](https://wpt.fyi/results/?sha=3cadaf1de3eff90e6dc53a29d2e2091609dddc69&label=pr_base)

Ran 6 tests

### Firefox
  PASS: 6

### Chrome
  PASS: 1
  FAIL: 5

### Safari
  PASS: 1
  FAIL: 5

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f790a3bd06e3
[wpt PR 19542] - [css-lists] Add list-style-type: <string>, a=testonly

Comment 6

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/f790a3bd06e3