158672 - editor doesn't consume (preventdefault) on characters typed in

Status: RESOLVED FIXED

(Core :: DOM: Editor, defect)

Description

[Kathleen :Brade]

While investigating a problem with Chimera, I found that the editor code
(nsPlaintextEditor.cpp) doesn't preventDefault for regular characters/letters
being typed.  I think this is a bug (right now, we only seem to prevent default
for delete/backspace, tab and return/enter).

Comment 1

[Kathleen :Brade]

Attachment: patch to be tested

This patch needs to be tested against many things to be sure there are no
regressions; any suggestions for regression testing?

Comment 2

[Kathleen :Brade]

-->brade

Comment 3

[Kathleen :Brade]

Akkana--can you review this?

Comment 4

[Akkana Peck]

Comment on attachment 92225 [details] [diff] [review]
patch to be tested

r=akkana

Comment 5

[Simon Fraser [no longer active]]

Comment on attachment 92225 [details] [diff] [review]
patch to be tested

sr=sfraser, but be sure to test this thoroughly, including IME etc.

Comment 6

[Charles Manske]

I tested the patch on Windows2K using the testcase attached to bug 26882 and
it prevents spacebar from causing the pagedown behavior.

Comment 7

[Kathleen :Brade]

fix checked into 1.2 trunk

Comment 8

[Kathleen :Brade]

fix checked into the 1.0 branch

Comment 9

[Kathleen :Brade]

reopening bug since this patch didn't address html editors

Comment 10

[Kathleen :Brade]

Attachment: patch for html editors

Comment 11

[Simon Fraser [no longer active]]

Comment on attachment 99557 [details] [diff] [review]
patch for html editors

sr=sfraser

Comment 12

[timeless]

Comment on attachment 99557 [details] [diff] [review]
patch for html editors

brade says that the other events are PreventDefault'd in
nsEditorEventListener.cpp

i wouldn't mind a comment to that effect, but r=timeless either way

Comment 13

[Kathleen :Brade]

fix checked in