Closed Bug 1586797 Opened 3 years ago Closed 3 years ago

Remove rooted string field from js::ErrorReport

Categories

(Core :: JavaScript Engine, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
mozilla71
Tracking Status
firefox71 --- fixed

People

(Reporter: anba, Assigned: anba)

Details

Attachments

(1 file)

No description provided.

The rooted string was added in bug 966452, because at that point of time
ownedReport.ucmessage was a direct pointer to a JSString's character
storage. But now that we're already copying the JSString characters to UTF-8,
it's no longer necessary to keep the JSString alive through the ErrorReport.

Pushed by rmaries@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/092249b346b2
Remove rooted string field from ErrorReport. r=mgaudet

Keywords: checkin-needed
Priority: -- → P1
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla71
You need to log in before you can comment on or make changes to this bug.