Closed Bug 1586804 Opened 2 years ago Closed 2 years ago

Make the node hide/unhide feature work with Fission

Categories

(DevTools :: Inspector, task, P1)

task

Tracking

(Fission Milestone:M4, firefox71 fixed)

RESOLVED FIXED
Firefox 71
Fission Milestone M4
Tracking Status
firefox71 --- fixed

People

(Reporter: pbro, Assigned: gl)

References

(Blocks 1 open bug)

Details

(Whiteboard: dt-fission-reserve)

Attachments

(1 file)

In the markup-view, you can hide/unhide nodes by pressing <H> on the keyboard. This feature will need fixing for it to work with Fission iframes.

Indeed, at least these lines of code will cause problems:

devtools/client/inspector/markup/markup.js:121-123
markupView.walker.unhideNode(node);
markupView.walker.hideNode(node);

We will need to instead use the walker that's contextual to the node being toggled.

Assignee: nobody → gl
Status: NEW → ASSIGNED
Priority: P3 → P1
Whiteboard: dt-fission-reserve → dt-fission
Whiteboard: dt-fission → dt-fission-reserve
Pushed by gluong@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/56a4078555c3
Use the contextual WalkerFront in the markup hide shortcut handler. r=pbro
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 71

Retroactively moving fixed bugs whose summaries mention "Fission" (or other Fission-related keywords) but are not assigned to a Fission Milestone to an appropriate Fission Milestone.

This will generate a lot of bugmail, so you can filter your bugmail for the following UUID and delete them en masse:

0ee3c76a-bc79-4eb2-8d12-05dc0b68e732

Fission Milestone: --- → M4
You need to log in before you can comment on or make changes to this bug.