1586898 - ASAN crash (OOM) under ResourceCache::add_blob_image on October 2

Status: RESOLVED WORKSFORME

(Core :: Graphics: WebRender, defect, P3)

Description

[Chris H-C :chutten]

In looking into bug 1556021 I noticed that a lot of the crashes being attributed to that intermittent are in fact WR crashes, not shutdown hangs like the original report.

It seems confined to October 2, autoland, reftests: https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1556021&startday=2019-09-30&endday=2019-10-06&tree=all

So maybe it's no longer an issue. But in case it is, I present this bug. Here's the crashing stack:

[task 2019-10-02T17:48:59.420Z] 17:48:59     INFO -     #0 0x7f43a86baf92 in MOZ_Crash /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/Assertions.h:332:3
[task 2019-10-02T17:48:59.421Z] 17:48:59     INFO -     #1 0x7f43a86baf92 in GeckoCrash /builds/worker/workspace/build/src/toolkit/xre/nsAppRunner.cpp:5117
[task 2019-10-02T17:48:59.421Z] 17:48:59     INFO -     #2 0x7f43aa8ec276 in gkrust_shared::panic_hook::h7e1e877b7a3b38e5 /builds/worker/workspace/build/src/toolkit/library/rust/shared/lib.rs:249:8
[task 2019-10-02T17:48:59.422Z] 17:48:59     INFO -     #3 0x7f43aa8ec19b in core::ops::function::Fn::call::hdacbcbad2ed62fb5 /rustc/eae3437dfe991621e8afdc82734f4a172d7ddf9b/src/libcore/ops/function.rs:69:4
[task 2019-10-02T17:48:59.424Z] 17:48:59     INFO -     #4 0x7f43ab22732c in std::panicking::rust_panic_with_hook::hffcefc09751839d1 /rustc/eae3437dfe991621e8afdc82734f4a172d7ddf9b/src/libstd/panicking.rs:481:16
[task 2019-10-02T17:48:59.425Z] 17:48:59     INFO -     #5 0x7f43ab22708d in std::panicking::continue_panic_fmt::hc0f142c930c846fc /rustc/eae3437dfe991621e8afdc82734f4a172d7ddf9b/src/libstd/panicking.rs:384:4
[task 2019-10-02T17:48:59.425Z] 17:48:59     INFO -     #6 0x7f43ab234cc5 in rust_begin_unwind /rustc/eae3437dfe991621e8afdc82734f4a172d7ddf9b/src/libstd/panicking.rs:311:4
[task 2019-10-02T17:48:59.427Z] 17:48:59     INFO -     #7 0x7f43ab23f2db in core::panicking::panic_fmt::h2daf88b2616ca2b2 /rustc/eae3437dfe991621e8afdc82734f4a172d7ddf9b/src/libcore/panicking.rs:85:13
[task 2019-10-02T17:48:59.428Z] 17:48:59     INFO -     #8 0x7f43ab241bb4 in core::slice::slice_index_order_fail::ha75fa70416d3bc2f /rustc/eae3437dfe991621e8afdc82734f4a172d7ddf9b/src/libcore/slice/mod.rs:2561:4
[task 2019-10-02T17:48:59.456Z] 17:48:59     INFO -     #9 0x7f43aabb3a4c in _$LT$core..ops..range..Range$LT$usize$GT$$u20$as$u20$core..slice..SliceIndex$LT$$u5b$T$u5d$$GT$$GT$::index::h3b8625ff26406283 /rustc/eae3437dfe991621e8afdc82734f4a172d7ddf9b/src/libcore/slice/mod.rs:2730:12
[task 2019-10-02T17:48:59.457Z] 17:48:59     INFO -     #10 0x7f43aabb3a4c in core::slice::_$LT$impl$u20$core..ops..index..Index$LT$I$GT$$u20$for$u20$$u5b$T$u5d$$GT$::index::h1dbcd50ae934a21f /rustc/eae3437dfe991621e8afdc82734f4a172d7ddf9b/src/libcore/slice/mod.rs:2538
[task 2019-10-02T17:48:59.458Z] 17:48:59     INFO -     #11 0x7f43aabb3a4c in webrender_bindings::moz2d_renderer::BlobReader::new::h374f790d763c6ed8 /builds/worker/workspace/build/src/gfx/webrender_bindings/src/moz2d_renderer.rs:206
[task 2019-10-02T17:48:59.458Z] 17:48:59     INFO -     #12 0x7f43aabb3a4c in _$LT$webrender_bindings..moz2d_renderer..Moz2dBlobImageHandler$u20$as$u20$webrender_api..image..BlobImageHandler$GT$::add::h3a5c1791af908d36 /builds/worker/workspace/build/src/gfx/webrender_bindings/src/moz2d_renderer.rs:613
[task 2019-10-02T17:48:59.621Z] 17:48:59     INFO -     #13 0x7f43aacbf03b in webrender::resource_cache::ResourceCache::add_blob_image::hd85eac216e15830a /builds/worker/workspace/build/src/gfx/wr/webrender/src/resource_cache.rs:994:8
[task 2019-10-02T17:48:59.621Z] 17:48:59     INFO -     #14 0x7f43aacbf03b in webrender::resource_cache::ResourceCache::pre_scene_building_update::h4fddb314b1b18cd9 /builds/worker/workspace/build/src/gfx/wr/webrender/src/resource_cache.rs:665
[task 2019-10-02T17:48:59.621Z] 17:48:59     INFO -     #15 0x7f43aacd73d6 in webrender::render_backend::RenderBackend::prepare_transactions::_$u7b$$u7b$closure$u7d$$u7d$::h3a9a3735f4239f51 /builds/worker/workspace/build/src/gfx/wr/webrender/src/render_backend.rs:1285:16
[task 2019-10-02T17:48:59.621Z] 17:48:59     INFO -     #16 0x7f43aacd73d6 in core::ops::function::impls::_$LT$impl$u20$core..ops..function..FnOnce$LT$A$GT$$u20$for$u20$$RF$mut$u20$F$GT$::call_once::h6fc05ace9adb4d5a /rustc/eae3437dfe991621e8afdc82734f4a172d7ddf9b/src/libcore/ops/function.rs:279
[task 2019-10-02T17:48:59.621Z] 17:48:59     INFO -     #17 0x7f43aacd73d6 in core::option::Option$LT$T$GT$::map::h455f906ea6372766 /rustc/eae3437dfe991621e8afdc82734f4a172d7ddf9b/src/libcore/option.rs:416
[task 2019-10-02T17:48:59.621Z] 17:48:59     INFO -     #18 0x7f43aacd73d6 in _$LT$core..iter..adapters..Map$LT$I$C$F$GT$$u20$as$u20$core..iter..traits..iterator..Iterator$GT$::next::hb70925b8bb9cb9c0 /rustc/eae3437dfe991621e8afdc82734f4a172d7ddf9b/src/libcore/iter/adapters/mod.rs:570
[task 2019-10-02T17:48:59.622Z] 17:48:59     INFO -     #19 0x7f43aacbce62 in _$LT$alloc..vec..Vec$LT$T$GT$$u20$as$u20$alloc..vec..SpecExtend$LT$T$C$I$GT$$GT$::from_iter::hf4b73e538fe5638e /rustc/eae3437dfe991621e8afdc82734f4a172d7ddf9b/src/liballoc/vec.rs:1883:31
[task 2019-10-02T17:48:59.623Z] 17:48:59     INFO -     #20 0x7f43aacbce62 in _$LT$alloc..vec..Vec$LT$T$GT$$u20$as$u20$core..iter..traits..collect..FromIterator$LT$T$GT$$GT$::from_iter::h72c14275b4a27d7d /rustc/eae3437dfe991621e8afdc82734f4a172d7ddf9b/src/liballoc/vec.rs:1796
[task 2019-10-02T17:48:59.623Z] 17:48:59     INFO -     #21 0x7f43aacbce62 in core::iter::traits::iterator::Iterator::collect::h3e38c15daaf6cc49 /rustc/eae3437dfe991621e8afdc82734f4a172d7ddf9b/src/libcore/iter/traits/iterator.rs:1466
[task 2019-10-02T17:48:59.623Z] 17:48:59     INFO -     #22 0x7f43aacbce62 in webrender::render_backend::RenderBackend::prepare_transactions::h6306c3b1e18980fa /builds/worker/workspace/build/src/gfx/wr/webrender/src/render_backend.rs:1266
[task 2019-10-02T17:48:59.623Z] 17:48:59     INFO -     #23 0x7f43aacbce62 in webrender::render_backend::RenderBackend::process_api_msg::hff35d97c5b62e3c5 /builds/worker/workspace/build/src/gfx/wr/webrender/src/render_backend.rs:1228
[task 2019-10-02T17:48:59.624Z] 17:48:59     INFO -     #24 0x7f43aaca9310 in webrender::render_backend::RenderBackend::run::hba911c0d6325e41c /builds/worker/workspace/build/src/gfx/wr/webrender/src/render_backend.rs:979:20
[task 2019-10-02T17:48:59.626Z] 17:48:59     INFO -     #25 0x7f43aaca1c59 in webrender::renderer::Renderer::new::_$u7b$$u7b$closure$u7d$$u7d$::h33cc4f56379072b0 /builds/worker/workspace/build/src/gfx/wr/webrender/src/renderer.rs:2196:12
[task 2019-10-02T17:48:59.628Z] 17:48:59     INFO -     #26 0x7f43aaca1c59 in std::sys_common::backtrace::__rust_begin_short_backtrace::h4685977f55c3b6e3 /rustc/eae3437dfe991621e8afdc82734f4a172d7ddf9b/src/libstd/sys_common/backtrace.rs:77
[task 2019-10-02T17:48:59.629Z] 17:48:59     INFO -     #27 0x7f43aac9f95d in std::thread::Builder::spawn_unchecked::_$u7b$$u7b$closure$u7d$$u7d$::_$u7b$$u7b$closure$u7d$$u7d$::hf7ac2ecc10ea471a /rustc/eae3437dfe991621e8afdc82734f4a172d7ddf9b/src/libstd/thread/mod.rs:470:16
[task 2019-10-02T17:48:59.629Z] 17:48:59     INFO -     #28 0x7f43aac9f95d in _$LT$std..panic..AssertUnwindSafe$LT$F$GT$$u20$as$u20$core..ops..function..FnOnce$LT$$LP$$RP$$GT$$GT$::call_once::h85e6590de777345e /rustc/eae3437dfe991621e8afdc82734f4a172d7ddf9b/src/libstd/panic.rs:315
[task 2019-10-02T17:48:59.630Z] 17:48:59     INFO -     #29 0x7f43aac9f95d in std::panicking::try::do_call::hd91bf313b2460fa0 /rustc/eae3437dfe991621e8afdc82734f4a172d7ddf9b/src/libstd/panicking.rs:296
[task 2019-10-02T17:48:59.631Z] 17:48:59     INFO -     #30 0x7f43aac9f95d in __rust_maybe_catch_panic /rustc/eae3437dfe991621e8afdc82734f4a172d7ddf9b/src/libpanic_abort/lib.rs:29
[task 2019-10-02T17:48:59.631Z] 17:48:59     INFO -     #31 0x7f43aac9f95d in std::panicking::try::hfb6d064e56cd2a56 /rustc/eae3437dfe991621e8afdc82734f4a172d7ddf9b/src/libstd/panicking.rs:275
[task 2019-10-02T17:48:59.631Z] 17:48:59     INFO -     #32 0x7f43aac9f95d in std::panic::catch_unwind::haadf7c626d61338a /rustc/eae3437dfe991621e8afdc82734f4a172d7ddf9b/src/libstd/panic.rs:394
[task 2019-10-02T17:48:59.632Z] 17:48:59     INFO -     #33 0x7f43aac9f95d in std::thread::Builder::spawn_unchecked::_$u7b$$u7b$closure$u7d$$u7d$::h04511ddca03a3b14 /rustc/eae3437dfe991621e8afdc82734f4a172d7ddf9b/src/libstd/thread/mod.rs:469
[task 2019-10-02T17:48:59.634Z] 17:48:59     INFO -     #34 0x7f43aac9f95d in core::ops::function::FnOnce::call_once$u7b$$u7b$vtable.shim$u7d$$u7d$::h508cf4ad85c0a7c9 /rustc/eae3437dfe991621e8afdc82734f4a172d7ddf9b/src/libcore/ops/function.rs:231
[task 2019-10-02T17:48:59.634Z] 17:48:59     INFO -     #35 0x7f43ab233c1d in _$LT$alloc..boxed..Box$LT$F$GT$$u20$as$u20$core..ops..function..FnOnce$LT$A$GT$$GT$::call_once::h42806b83647d4c79 /rustc/eae3437dfe991621e8afdc82734f4a172d7ddf9b/src/liballoc/boxed.rs:746:8
[task 2019-10-02T17:48:59.635Z] 17:48:59     INFO -     #36 0x7f43ab235ec7 in _$LT$alloc..boxed..Box$LT$F$GT$$u20$as$u20$core..ops..function..FnOnce$LT$A$GT$$GT$::call_once::h83c921c8e826dd1d /rustc/eae3437dfe991621e8afdc82734f4a172d7ddf9b/src/liballoc/boxed.rs:746:8
[task 2019-10-02T17:48:59.635Z] 17:48:59     INFO -     #37 0x7f43ab235ec7 in std::sys_common::thread::start_thread::h2613204ce513782e /rustc/eae3437dfe991621e8afdc82734f4a172d7ddf9b/src/libstd/sys_common/thread.rs:13
[task 2019-10-02T17:48:59.636Z] 17:48:59     INFO -     #38 0x7f43ab235ec7 in std::sys::unix::thread::Thread::new::thread_start::h4570080769500bcd /rustc/eae3437dfe991621e8afdc82734f4a172d7ddf9b/src/libstd/sys/unix/thread.rs:79
[task 2019-10-02T17:48:59.636Z] 17:48:59     INFO -     #39 0x7f43bdbca6b9 in start_thread (/lib/x86_64-linux-gnu/libpthread.so.0+0x76b9)
[task 2019-10-02T17:48:59.684Z] 17:48:59     INFO -     #40 0x7f43bcc5341c in clone /build/glibc-LK5gWL/glibc-2.23/misc/../sysdeps/unix/sysv/linux/x86_64/clone.S:109

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The priority flag is not set for this bug.
:jbonisteel, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 2

[Nicolas Silva [:nical]]

OOM crash. I wouldn't spend too much time on this since blobs can be arbitrarily large so there's no fully preventing OOMs there until we have fallible rust vector allocation, and we also have performance bugs on file related to the size if blob image recordings.

Comment 3

[Glenn Watson [:gw]]

No longer occurring.