Improve browser_eventDialogModificationPrompt.js
Categories
(Calendar :: Dialogs, defect)
Tracking
(Not tracked)
People
(Reporter: darktrojan, Assigned: darktrojan)
Details
Attachments
(1 file)
6.50 KB,
patch
|
pmorris
:
review+
|
Details | Diff | Splinter Review |
Since moving to mochitest this test is failing catastrophically when it fails. I think the reason is the strange way it detects a prompt to save and dismisses it, which is the whole point of the test.
Assignee | ||
Comment 1•5 years ago
|
||
I've changed the test to listen for any save prompt, and fail immediately if it appears. I also made it wait for 2 seconds when closing the event dialog, which isn't strictly necessary but might help.
Note this doesn't solve the "couldn't click on the all-day checkbox" problem that is affecting this and some other tests, but it does stop this test from timing out and killing the rest of the directory's tests.
Comment 2•5 years ago
|
||
Comment on attachment 9099495 [details] [diff] [review] 1586979-modification-prompt-test-1.diff Review of attachment 9099495 [details] [diff] [review]: ----------------------------------------------------------------- Changes look reasonable, and test passes locally for me. r+ with one little nit addressed. ::: calendar/test/browser/eventDialog/browser_eventDialogModificationPrompt.js @@ +115,2 @@ > event.keypress(null, "VK_ESCAPE", {}); > + // Wait to see if the prompt appears. Just for good measure: "Wait to see if the save event prompt appears."
Comment 3•5 years ago
|
||
Comment on attachment 9099495 [details] [diff] [review] 1586979-modification-prompt-test-1.diff Review of attachment 9099495 [details] [diff] [review]: ----------------------------------------------------------------- Forgot the +.
Assignee | ||
Comment 4•5 years ago
|
||
Note to self: address the review comments before checking in.
(I bet I still forget.)
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/55f15b85ce9b
Improve browser_eventDialogModificationPrompt.js. r=pmorris DONTBUILD
Updated•5 years ago
|
Description
•