Closed Bug 1586981 Opened 5 years ago Closed 5 years ago

[wpt-sync] Sync PR 19563 - Turn on backpressure for blink::WebSocketStream sooner

Categories

(Core :: Networking: WebSockets, task, P4)

Product:
Core
Component:
Networking: WebSockets
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla71
Tracking Flags:
Tracking Status
firefox71 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream][necko-triaged])

Sync web-platform-tests PR 19563 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/19563
Details from upstream follow.

Adam Rice <ricea@chromium.org> wrote:

Turn on backpressure for blink::WebSocketStream sooner

Apply backpressure to blink::WebSocketChannel before the WebSocketStream
handshake starts, rather than after it completes. This avoids a race
condition where more of the first message is read than should be.

Also fix flakiness in the
external/wpt/websockets/stream-tentative/backpressure-receive.any.js by
doubling the size of message used.

BUG=1002780

Change-Id: I915c71a4b81b95375b7c4c584f7782d5336cba85
Reviewed-on: https://chromium-review.googlesource.com/1844911
WPT-Export-Revision: 7c8d20c6de5fff6e203ebcb02706f9fa2db32e6e

Component: web-platform-tests → Networking: WebSockets
Product: Testing → Core
## GitHub CI Results
wpt.fyi [PR Results](https://wpt.fyi/results/?sha=cd0de171e164232f98b123e971645ab17ab3c53a&label=pr_head) [Base Results](https://wpt.fyi/results/?sha=cd0de171e164232f98b123e971645ab17ab3c53a&label=pr_base)

Ran 4 tests and 5 subtests

### Firefox
  OK     : 4
  FAIL   : 4

### Chrome
  OK     : 4
  PASS   : 4

### Safari
  OK     : 4
  FAIL   : 4

### New tests that's don't pass

/websockets/stream-tentative/backpressure-receive.any.sharedworker.html
   backpressure-receive: Firefox: MISSING, Chrome: MISSING, Safari: FAIL
Whiteboard: [wptsync downstream] → [wptsync downstream][necko-triaged]
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/cdc6a42731a9
[wpt PR 19563] - Turn on backpressure for blink::WebSocketStream sooner, a=testonly

https://hg.mozilla.org/mozilla-central/rev/cdc6a42731a9

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox71: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla71
You need to log in before you can comment on or make changes to this bug.